Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1846 Add support for TLS PSK #1847

Merged
merged 4 commits into from
Jul 21, 2024
Merged

fixes #1846 Add support for TLS PSK #1847

merged 4 commits into from
Jul 21, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jul 21, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 97.40260% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.49%. Comparing base (8c5142a) to head (3235c2f).

Files Patch % Lines
src/supplemental/tls/mbedtls/tls.c 96.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   79.35%   79.49%   +0.13%     
==========================================
  Files          95       95              
  Lines       21543    21612      +69     
==========================================
+ Hits        17095    17180      +85     
+ Misses       4448     4432      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore force-pushed the gdamore/tls-psk branch 4 times, most recently from fcd801c to 2f84307 Compare July 21, 2024 19:29
@gdamore gdamore force-pushed the gdamore/tls-psk branch 2 times, most recently from 11e95e4 to a84e21c Compare July 21, 2024 21:19
This also adds an SP layer transport test for TLS, based on the TCP
test but with some additions; this test does not cover all the edge
cases for TLS, but it does at least show how to use it.
@gdamore gdamore merged commit d6c9c11 into master Jul 21, 2024
16 checks passed
@gdamore gdamore deleted the gdamore/tls-psk branch November 8, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant