Add external events and drivers #43

networkfusion · 2021-08-12T18:25:00Z

Description

Superseeds #41. The replacement of Windows.Storage does not include detection of removable devices. Although this is (was) only available with UWP, it is very important in nanoFramework. It also includes another class for initializing external devices that are not part of the native framework.

Uses namespace System.IO.nanoFramework for ExternalDrivers and Events.

Motivation and Context

Adds support for removable devices and external driver support.

How Has This Been Tested?

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (work on Unit Tests, has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Attempts to find issues with build! Removes invalid solution project defefinition.

System.IO.FileSystem/nanoFramework/ExternalDriver.cs

- Rename namespace. - Rename class. - Add data width enum to make the parameter clear (same weight on interface size and processing for native code). - Split MountSpi method to make it clear that an fixed configuration option is available. - Adjusted documentation. - Rework using for System.Diagnostics namespace.

- Also removed static using which was causing MDP to fail.

josesimoes · 2021-08-26T11:12:40Z

~~@networkfusion this is building again. The failure was being caused by using a static using .~~

Actually is not on the pipeline... I'll have to figure out why... 😞

josesimoes · 2021-08-26T11:13:27Z

@networkfusion @Ellerbach @AdrianSoundy please review and comment the revied API in SDCard class.

AdrianSoundy · 2021-09-02T05:32:05Z

Tried to do some testing with this but it's not building. RemovableDeviceEvent not found. Looks like it in wrong position in code.
Moved it but then got a strange MDP error, so gave up
@josesimoes

Source code changes looked ok.

josesimoes · 2021-09-02T08:17:31Z

@networkfusion @AdrianSoundy issue related with MDP fixed. This is now building OK. Really really OK 😅 !

AdrianSoundy · 2021-09-03T23:03:18Z

Ok i have it building now. I'll see if a can do some testing in next few days.

AdrianSoundy · 2021-09-06T01:12:30Z

Is there any native code for these changes ? I couldn't find them.
@josesimoes @networkfusion

josesimoes · 2021-09-06T06:04:49Z

Is there any native code for these changes ? I couldn't find them.
@josesimoes @networkfusion

Nope. Robin was adjusting the C# to bring in the "missing" classes for card detection and such.

AdrianSoundy · 2021-09-07T10:23:47Z

Ok i'll look at adding the native code required so i can test it
@josesimoes

AdrianSoundy · 2021-09-09T21:35:58Z

Update:-
I added native code for ESP32 and in the process of testing. For other devices will just get NOT implemented exception for now.
Seems to work ok with 1bit & 4 Bit MMC interfaces. With SPI seems to be very selective on SDcard used.

Will look at doing a card Insert event as well but will need to know the GPIO used for that from managed code.

Still need to tidy things up and looking at making it possible to just load System.IO.Filesystem without Window.Devices.Storage.
Also noticed GetDirectories is not working but cards mount OK

There is an outstanding problem. You can't access the Internal partition as its now fixed to FAT32 where partition is Spiffs.
Windows.Devices.Storage used VFS to access both.

AdrianSoundy · 2021-09-15T06:27:08Z

There is no way to specify a GPIO for detecting the SD card insertion unless its hard coded in the build.

Maybe we should create an instance of a SDCard class instead of a static class with constructors for MMC & SPI with an optional Inserted GPIO number. Then native code can fire event when card inserted. Also have an inserted property

@josesimoes @networkfusion

networkfusion · 2021-09-15T11:21:07Z

@AdrianSoundy Sounds sensible to me... but would have to rely on @josesimoes for thoughts...

josesimoes · 2021-09-15T12:31:00Z

There is already nanoframework/Home#808 which is kind of inline with this.

🆗 I'm quite all right with adding those constructors with those parameters. Those should be overloads to the parameterless one.

⚠️ And any changes (both C# and native) must not harm the current implementation for hard coded SD card detection (which ChibiOS has out of the box).

Changed from static class so it could be initialised with parameters Then is can be used either by polling IsCardDetected state or waiting for event via StorageEventManager

AdrianSoundy · 2021-09-18T01:26:24Z

@josesimoes @networkfusion
Can you have a look at latest change before a update native stuff.

josesimoes

Looking good!

README.md

System.IO.FileSystem/nanoFramework/SDCard.cs

AdrianSoundy · 2021-09-19T11:12:51Z

@josesimoes Seems to be failing with a error in powershell build script, can you have a look

josesimoes · 2021-09-19T16:31:34Z

@AdrianSoundy all green now

Add IDisposable and renames Changed native to pick up parameters form class etc

…mework/System.IO.FileSystem into develop-removable-events

josesimoes

LGTM! I've missed this last request for a review. Apologies.

nfbot added the Type: enhancement New feature or request label Aug 12, 2021

networkfusion added 2 commits August 26, 2021 11:17

Add external events and drivers.

02ba2f7

Revert storage events.

c101555

Attempts to find issues with build! Removes invalid solution project defefinition.

josesimoes reviewed Aug 26, 2021

View reviewed changes

System.IO.FileSystem/nanoFramework/ExternalDriver.cs Outdated Show resolved Hide resolved

josesimoes reviewed Aug 26, 2021

View reviewed changes

System.IO.FileSystem/nanoFramework/ExternalDriver.cs Outdated Show resolved Hide resolved

josesimoes reviewed Aug 26, 2021

View reviewed changes

System.IO.FileSystem/nanoFramework/ExternalDriver.cs Outdated Show resolved Hide resolved

josesimoes force-pushed the develop-removable-events branch 2 times, most recently from 48120b0 to 81c32a8 Compare August 26, 2021 10:59

josesimoes force-pushed the develop-removable-events branch from 81c32a8 to 72c34f9 Compare August 26, 2021 10:59

josesimoes added 5 commits August 26, 2021 12:03

Rename namespaces

ba1c049

- Also removed static using which was causing MDP to fail.

Fix line endings in file

38d4b85

Fix typos in readme

acf9b12

Fix nuspec

30db4f5

Adjust Azure pipelines yaml

3e82c6f

josesimoes added the Status: in progress label Aug 26, 2021

Add global files to solution

beac9f8

josesimoes added 2 commits September 2, 2021 09:03

Rename namespace

c6e26dd

Remove NFMDP_PE_LoadHints from nfproj

00d3a6c

josesimoes changed the title ~~Add external events and drivers.~~ Add external events and drivers Sep 12, 2021

Update SDCard for card detect pin

7cbb856

Changed from static class so it could be initialised with parameters Then is can be used either by polling IsCardDetected state or waiting for event via StorageEventManager

josesimoes requested changes Sep 18, 2021

View reviewed changes

Changes from review

b1c4342

Merge branch 'develop' into develop-removable-events

fb23608

AdrianSoundy added 3 commits October 10, 2021 15:48

Update sdcard.cs

31bc1d4

Add IDisposable and renames Changed native to pick up parameters form class etc

Merge branch 'develop-removable-events' of https://github.com/nanofra…

05b6f2a

…mework/System.IO.FileSystem into develop-removable-events

Merge branch 'develop' into develop-removable-events

c0b881c

AdrianSoundy requested a review from josesimoes October 10, 2021 02:55

josesimoes approved these changes Oct 11, 2021

View reviewed changes

josesimoes merged commit fd439c6 into develop Oct 11, 2021

josesimoes deleted the develop-removable-events branch October 11, 2021 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add external events and drivers #43

Add external events and drivers #43

networkfusion commented Aug 12, 2021 •

edited by josesimoes

Loading

josesimoes commented Aug 26, 2021 •

edited

Loading

josesimoes commented Aug 26, 2021

AdrianSoundy commented Sep 2, 2021

josesimoes commented Sep 2, 2021

AdrianSoundy commented Sep 3, 2021 •

edited

Loading

AdrianSoundy commented Sep 6, 2021 •

edited

Loading

josesimoes commented Sep 6, 2021

AdrianSoundy commented Sep 7, 2021

AdrianSoundy commented Sep 9, 2021 •

edited

Loading

AdrianSoundy commented Sep 15, 2021 •

edited

Loading

networkfusion commented Sep 15, 2021

josesimoes commented Sep 15, 2021

AdrianSoundy commented Sep 18, 2021

josesimoes left a comment

AdrianSoundy commented Sep 19, 2021

josesimoes commented Sep 19, 2021

josesimoes left a comment

Add external events and drivers #43

Add external events and drivers #43

Conversation

networkfusion commented Aug 12, 2021 • edited by josesimoes Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

josesimoes commented Aug 26, 2021 • edited Loading

josesimoes commented Aug 26, 2021

AdrianSoundy commented Sep 2, 2021

josesimoes commented Sep 2, 2021

AdrianSoundy commented Sep 3, 2021 • edited Loading

AdrianSoundy commented Sep 6, 2021 • edited Loading

josesimoes commented Sep 6, 2021

AdrianSoundy commented Sep 7, 2021

AdrianSoundy commented Sep 9, 2021 • edited Loading

AdrianSoundy commented Sep 15, 2021 • edited Loading

networkfusion commented Sep 15, 2021

josesimoes commented Sep 15, 2021

AdrianSoundy commented Sep 18, 2021

josesimoes left a comment

Choose a reason for hiding this comment

AdrianSoundy commented Sep 19, 2021

josesimoes commented Sep 19, 2021

josesimoes left a comment

Choose a reason for hiding this comment

networkfusion commented Aug 12, 2021 •

edited by josesimoes

Loading

josesimoes commented Aug 26, 2021 •

edited

Loading

AdrianSoundy commented Sep 3, 2021 •

edited

Loading

AdrianSoundy commented Sep 6, 2021 •

edited

Loading

AdrianSoundy commented Sep 9, 2021 •

edited

Loading

AdrianSoundy commented Sep 15, 2021 •

edited

Loading