-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Removable Storage Events. #41
Conversation
TODO: add classes to an nfproj.
Comment on possible better handling of drive letter.
Includes TODO comments which should be removed after review!
Update nerdbank version.
Of note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, I haven't been really using the Windows storage class so I don't really have a strong opinion on all this.
Only strong one is to go for simplicity and harmonize all storage access, including the non removable one.
} | ||
} | ||
|
||
internal static string DriveIndexToPath(byte driveIndex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this part may not be needed or then better documented. Or at least contains somehow the non removable storage as well. Like C:
It's the moment to simplify all the complexity introduced by the Windows namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could use the https://docs.microsoft.com/en-us/dotnet/api/system.io.driveinfo?view=net-5.0 class instead of this (I only learnt about it yesterday). That would also be more fitting with nanoframework/Home#799
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it makes sense. Still, we need the events as they don't seem to exist on any .NET namespaces...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of System.IO.FileSystem library. Why the need for a separate assembly?
Closing as superseeded. |
Description
Motivation and Context
The replacement of
Windows.Storage
does not include detection of removable devices. Although this is (was) only available with UWP, it is very important in nanoFramework. This PR is a first attempt to work out the best possible approach,Comments welcome, and extra input relating to nanoframework/Home#799 advisable.
How Has This Been Tested?
None yet. It requires the native implementation to be added!
Screenshots
Types of changes
Checklist: