Pulling Uniswap MKR/ETH price via Multicall contract #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title I am now pulling the MKR/ETH price from the Uniswap MKR exchange contract via Multicall. To do this I am
getTokenToEthInputPricewhich returns the amount of ETH that can be bought for a 1 token of MKRFor reference: https://docs.uniswap.io/smart-contract-api/exchange#getethtotokeninputprice
Here's are some screenshots!
Note: I believe I found a bug in ethers.js v5.0-beta and had to filter methods that are marked as not payable and not constant. I opted to filter the ABI at runtime because it is more explicit than modifying the ABI. I've left a comment in the code and opened a ticket with ethers.js
Closes #56