Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Metrics: Under SCD MKR price, show uniswap MKR/ETH price #56

Closed
ddaws opened this issue Mar 19, 2020 · 1 comment
Closed

Extra Metrics: Under SCD MKR price, show uniswap MKR/ETH price #56

ddaws opened this issue Mar 19, 2020 · 1 comment

Comments

@ddaws
Copy link

ddaws commented Mar 19, 2020

Pulled from #49 so I can take this one :)
@ddaws
Copy link
Author

ddaws commented Mar 19, 2020

I had to do a little extra digging because I think there may be an issue with ethers v5.0-beta parsing ABIs containing functions that are non-payable and non-constant. I've created an issue here Fail to create contract instance from Contract with non-payable and non-constant function in ethers v5.0-beta ethers-io/ethers.js#762

@ddaws ddaws mentioned this issue Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pulling Uniswap MKR/ETH price via Multicall contract ddaws/daistats
2 participants
@devenoges @ddaws