Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDomain: Fix DNS Delegation issue #1

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Conversation

nanderh
Copy link
Owner

@nanderh nanderh commented Nov 25, 2020

Added fix for issue dsccommunity#176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235

Pull Request (PR) description

Added fix for above issues by:

  • Adding InstallDNS switch if the DnsDelegationCredential option has been used
  • Starting the netlogon service after domain installation

This Pull Request (PR) fixes the following issues

Fixes issue dsccommunity#176 ADDomain: DNS Delegation is no longer working.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

Added fix for issue dsccommunity#176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235
@nanderh nanderh merged commit 8a30592 into master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant