Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDomain: DNS Delegation is no longer working. #176

Open
RobBiddle opened this issue Jan 11, 2018 · 2 comments
Open

ADDomain: DNS Delegation is no longer working. #176

RobBiddle opened this issue Jan 11, 2018 · 2 comments
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@RobBiddle
Copy link

RobBiddle commented Jan 11, 2018

DNS Delegation is no longer working.

In version 2.14 DNS Delegation for Child Domains was working fine.
In 2.16 it no longer works.

I'm fairly certain it's due to changes in 2.15, specifically this change @iainbrighton 7223fbc#diff-a7c07329742e59a436bee9ed08a3f411L232

That looks like it was a major breaking change.

If the InstallDns parameter is no longer being sent to Install-ADDSForest/Install-ADDSDomain then it makes the DnsDelegationCredential Resource Property useless

@RobBiddle
Copy link
Author

Ideally this change should be reverted.

Alternatively a DSC Resource Property for InstallDns could be added, which would still be a breaking change from previous releases.

If this DSC Resource is going to remain as-is then there needs to be a test for the presence of the DNS server feature, at-least when the user specifies DnsDelegationCredential (which implies the user needs/wants DNS running on the domain controller).

@johlju
Copy link
Member

johlju commented May 8, 2018

This seems to have been removed "temporarily" discussed in issue #74, but the new planned functionality was never implemented, and the prior functionality was never reverted. Agree that this should be added back in, in a way that wouldn't make a breaking change again.

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 8, 2018
@johlju johlju changed the title DNS Delegation is no longer working. ADDomain: DNS Delegation is no longer working. Jul 28, 2019
nanderh added a commit to nanderh/ActiveDirectoryDsc that referenced this issue Nov 25, 2020
Added fix for issue dsccommunity#176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

2 participants