Configurable database #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuelhds
force-pushed
the
feature/configurable-database
branch
from
46d8bbd to
7f168c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT. Do not merge yet. I'll be testing this in the real world today
Now the database connection is handled with the
dbproperty directly and using URL database connections. If nodbprop is defined, the valuesqlite:///diffengine.dbis used in order to maintain compatibility.With this method, you can use MySQL, PostgreSQL or any other engine supported by peewee.
More info about database url connections here
Non related
I've create a suite for the feed tests and I've independizate them as well for easier testing