Changes for 1.6.6 release #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With tests to verify it is accepted and parsed in the policy.
…, but this also breaks 1 test case for some reason.
Add deprecated annotations for XHTML
…ions to the latest 5.x versions. Required updating imports and rewriting a bit of code in the CssScanner class.
davewichers
reviewed
Apr 2, 2022
| @@ -167,7 +167,7 @@ public CssHandler(Policy policy, List<String> errorMessages, ResourceBundle mess | |||
| * the tag name associated with this inline style | |||
| */ | |||
| public CssHandler(Policy policy, List<String> errorMessages, ResourceBundle messages, String tagName) { | |||
| this(policy, null, new ArrayList<String>(), tagName, messages); | |||
| this(policy, null, errorMessages, tagName, messages); | |||
There was a problem hiding this comment.
Was this just a bug in AntiSamy 1.6.5 or earlier?
|
Yes, it was reported in 1.6.5 for error messages on CSS scans that were not
appearing in the result. Recent issue.
…On Sat, 2 Apr 2022 at 11:17 Dave Wichers ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/org/owasp/validator/css/CssHandler.java
<#162 (comment)>:
> @@ -167,7 +167,7 @@ public CssHandler(Policy policy, List<String> errorMessages, ResourceBundle mess
* the tag name associated with this inline style
*/
public CssHandler(Policy policy, List<String> errorMessages, ResourceBundle messages, String tagName) {
- this(policy, null, new ArrayList<String>(), tagName, messages);
+ this(policy, null, errorMessages, tagName, messages);
Was this just a bug in AntiSamy 1.6.5 or earlier?
—
Reply to this email directly, view it on GitHub
<#162 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHL3BMKJZSY522FVKX37XGTVDBJGZANCNFSM5SKAQ4FA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styletags.