Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated annotations for XHTML #158

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

spassarop
Copy link
Collaborator

No description provided.

@spassarop
Copy link
Collaborator Author

@davewichers I could add warnings on logic flows which assume XHTML is used if you think those deprecations are not enough.

The problem is that it's only one if-block. Other usages are inline and I cannot determine which value the directive has, like:

transformer.setOutputProperty(OutputKeys.METHOD, useXhtml ? "xml" : "html");

Then it may not be that useful. The other option is to always warn, which may be a lot (or not?).

@davewichers
Copy link
Collaborator

I think this is good enough for now.

@davewichers davewichers merged commit 05f041a into nahsra:1.6.6 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants