Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling collapsable labels #20

Closed
zam6ak opened this issue Dec 2, 2016 · 5 comments
Closed

styling collapsable labels #20

zam6ak opened this issue Dec 2, 2016 · 5 comments

Comments

@zam6ak
Copy link

zam6ak commented Dec 2, 2016

I would like to add cursor: pointer to row and column labels that are collapsible.
But classes alone do not differentiate between collapsible vs non-collapsible columns and rows.
At least not that I can see (e.g. classes pvtRowLabel and pvtAxisLabel)

Is there a way to accomplish this?

nagarajanchinnasamy pushed a commit that referenced this issue Dec 7, 2016
@nagarajanchinnasamy
Copy link
Owner

@zam6ak Thanks for your feedback :)

One of expanded andcollapsed classes is added to headers and labels based on their current status. Changes regarding this are committed to master.

Please check and confirm if the changes are fine.

@nagarajanchinnasamy
Copy link
Owner

Feature incorporated into Version 1.1.1

@zam6ak
Copy link
Author

zam6ak commented Dec 13, 2016

@nagarajanchinnasamy I think the label should be wrapped in span element and then that span should be either collapsed or expanded. Right now, on tall columns, entire cell is click-able (with pointer: cursor).
Unless that was by design....Is it? (meaning if I vertically align to top a collapsible, tall column - should clicking anywhere in that cell expand it or just when clicking on the table)?

@zam6ak
Copy link
Author

zam6ak commented Dec 13, 2016

@nagarajanchinnasamy Also, may be usefull to add some notes to new CSS file about interference with Heatmap renderer...This is what I have:

table.pvtTable .collapsed,  table.pvtTable .expanded {
    cursor: pointer
}

/* applying following styles interferes with Heatmap renderer */
/*
table.pvtTable .pvtRowSubtotal {
    background-color: #efefef !important;
    font-weight: bold;
}

table.pvtTable .pvtColSubtotal {
    background-color: #efefef !important;
    font-weight: bold;
}
*/

@nagarajanchinnasamy
Copy link
Owner

@zam6ak Thanks for the feedback.

Yes I deliberately left the whole cell clickable so that users don;t have to exactly place the mouse on the label to click. Hope that;s more convenient!!!

Also I will add the notes to CSS on interference with heatmap renderer. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants