Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic hello world package - taken from rumprun project #2

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

useidel
Copy link
Contributor

@useidel useidel commented Aug 25, 2018

For an even easier start I have created a package which basically re-uses the "Hello World" example from the rumprun project and creates the package for Nabla/Rumprun/Solo5 framework.

@useidel
Copy link
Contributor Author

useidel commented Aug 25, 2018

There is a dependency on a pull request of a related repository: http://github.com/nabla-containers/nabla-base-build/pull/10

Copy link
Contributor

@ricarkol ricarkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks! just one nit about the compressed source files.

hello/Makefile Outdated
@@ -0,0 +1,22 @@
include ../Makefile.inc
UPSTREAM=hello.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to have the source files uncompressed, so people can play with them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - ok. Okies ... will do so.

@useidel
Copy link
Contributor Author

useidel commented Aug 27, 2018

code updated as advised

@ricarkol
Copy link
Contributor

Thanks

@ricarkol ricarkol merged commit c48e017 into nabla-containers:solo5 Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants