-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hello-base package using basic hello world package (from rumprun) #10
base: master
Are you sure you want to change the base?
Conversation
There is a dependency to a pull request to a related repository: http://github.com/nabla-containers/rumprun-packages/pull/2 |
Thanks for the PR @useidel. I suggest one change. A hello world app would fit better in the |
@ricarkol: thanks for the suggestion. I need a bit more time to think about that. If I got it right after a swift check than basic flow would be:
|
That's right. This would would just include the C code, a Makefile, and a Dockerfile. The Dockerfile would inherit from
This new |
@ricarkol: Thanks again - fully understood now. I would say creating the "nabla-cc-base" is by far the tricky part. Thanks for helping out here. I will re-work this PR to be ready once we have the base image. Will post once this is done (and if any assumptions/prereqs need to be considered). |
Hi @useidel, sorry for the late reply. We are still trying to figure out how to organize the base images (like what should be a base image for nabla). |
@ricarkol: No worries - I was not able to do some serious work here myself |
I had some time to give this topic more thoughts. And now I think we need to change the direction a little bit. Our current Hello World approac is a bit different than the other examples (nodes, nginx, redis, ...). There the the basic binary is part of the base image and the demo-app part delivers "only" a configuration file or other ASCII data. |
@ricarkol: Ah - ok I will take look at the go case. |
@ricarkol : Ok, I think I got a handle on it - well actually the C case. The only not-working thing is the creation of the docker image/instance. I think there is no need to revert nabla-containers/rumprun-packages#2 |
Yeah, let's keep the rumprun-packages change. Let us know when you are ready. |
Let's rebase this since it's been a while from the master branch. |
Integration of submitted hello world package to rumprun-packages. That one uses the "Hello World" example from the rumprun project as base for "package"