Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix stopping and retrying failed executions #8480

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 29, 2024

@ivov ivov marked this pull request as draft January 29, 2024 15:00
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 29, 2024
@ivov ivov marked this pull request as ready for review January 29, 2024 15:10
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed that the tests will be on #8424 since it touches similar files and we need to fix this bug urgently

@ivov
Copy link
Contributor Author

ivov commented Jan 29, 2024

Discussed with @krynble - because these files were heavily refactored in #8424 and because we need this fix in master, we will add the tests for these two issues in #8424.

Copy link

cypress bot commented Jan 29, 2024

1 flaky test on run #3951 ↗︎

0 339 5 0 Flakiness 1

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: 238b54c77b
Status: Passed Duration: 03:42 💡
Started: Jan 30, 2024 3:10 AM Ended: Jan 30, 2024 3:14 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8480 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 238b54c into master Jan 29, 2024
31 checks passed
@ivov ivov deleted the pay-1320-retry-workflow-failing branch January 29, 2024 15:34
MiloradFilipovic added a commit that referenced this pull request Jan 30, 2024
…error-states

* master:
  fix(editor): Send template id as a number in telemetry events (#8484)
  refactor(core): Replace promisify-d node calls with native promises (no-changelog) (#8464)
  fix(core): Fix stopping and retrying failed executions (#8480)
  feat: Add model parameter to OpenAI embeddings (#8481)
  fix(editor): Disable expression editor modal opening on readonly field (#8457)
  fix(core): Prevent calling internal hook email event if emailing is disabled (#8462)
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
@janober
Copy link
Member

janober commented Feb 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants