fix(editor): Disable expression editor modal opening on readonly field #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fields-appear-editable-when-they-should-be-in
n8n-assistant
bot
added
n8n team
|
Thanks for fixing this! Added a comment about the requirements on Linear. |
|
Thanks @ivov, sorry, I just missed it. |
|
So readonly works fine, but I'm still seeing this white instead of greyed out. Let's sync on this when you get a chance. 
|
…-fields-appear-editable-when-they-should-be-in
ivov
approved these changes
Jan 29, 2024
1 flaky test on run #3950 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Execution > should test manual workflow stop |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8457 ↗︎
|
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-1000-expression-fields-appear-editable-when-they-should-be-in
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 30, 2024
…error-states * master: fix(editor): Send template id as a number in telemetry events (#8484) refactor(core): Replace promisify-d node calls with native promises (no-changelog) (#8464) fix(core): Fix stopping and retrying failed executions (#8480) feat: Add model parameter to OpenAI embeddings (#8481) fix(editor): Disable expression editor modal opening on readonly field (#8457) fix(core): Prevent calling internal hook email event if emailing is disabled (#8462)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression fields appear editable when they should be in read only state
m
We need to look at expression fields across all nodes to make sure they are 'read only' when a credential on them is being used that isn't shared with the user currently editing. There are a few different scenarios to consider. One is where you're an instance owner/admin and more things look editiable than they should be. The other is that it looks like even for standard member users, expression fields/text input fields are editable when they shouldn't be
Expected behaviour
When editing the Google sheets node where the credential has not been shared with you, you should not be able to edit any of the fields on that nodes.
When opening up the expression editor in full screen mode, it should be greyed out and in read only mode
Actual behaviour
Expression/text fields on certain nodes (if not all) are still editable. You can't save them but its confusing because it looks like you can update and save them and you won't see any error messages. Any changes will just disappear once you refresh.
For certain nodes, you're unable to edit in the small expressions input but once you open up in full screen you can then edit things in there
A/C
Expressions on readonly (when credentials have not been shared) nodes should be readonly for instance owner, instance admin and member users
When you open up the expression editor in full screen mode on any node, this should also be in read only state.
We should check all nodes are handling expressions/text inputs like this consistently
Examples of where this is happening
GMAIL Node - you can't edit the message in the initial view but once you open up to full screen editor you then can
Google Sheets node - You can edit the values to send fields when they should be read only like the fields above
