fix(core): Fix test webhook deregistration #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
…tering-webhooks-in-manual
krynble
reviewed
Jan 8, 2024
krynble
approved these changes
Jan 9, 2024
|
|
2 flaky tests on run #3675 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Screenshots
Video
|
|
Review all test suite changes for PR #8247 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-1205-bug-linear-trigger-is-not-deregistering-webhooks-in-manual
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 10, 2024
* master: ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271) fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280) fix: Fix issue with API key being required for the Qdrant Node (#8237) feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771) fix(FTP Node): FTP connection failed due to missing password credential in node (#8131) ci: Fix lint setup in `chat` package (no-changelog) (#8275) ci: Fix codecov reporting, and include all packages (no-changelog) (#8276) fix(core): Fix test webhook deregistration (#8247) docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273) fix: Fix user reinvites on FE and BE (#8261) docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270) feat: Add Chat Trigger node (#7409) fix(Github Trigger Node): Enforce SSL validation by default (#8265) fix(editor): Tweaking button sizes in execution preview (#8206) fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1205