Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Tweaking button sizes in execution preview #8206

Merged

Conversation

jesper-bylund
Copy link
Contributor

Summary

Changed the size of the buttons on the execution preview in the executions history.
n00b contributor, please point out errors I'm making!

Related tickets and issues

https://linear.app/n8n/issue/PAY-1176/improve-hierarchy-of-workflow-executions-view

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@jesper-bylund jesper-bylund changed the title fix(editor): tweaked button size fix(editor): Tweaked button size Jan 3, 2024
@jesper-bylund jesper-bylund changed the title fix(editor): Tweaked button size fix(editor): Tweaking button sizes in execution preview Jan 3, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 3, 2024

2 flaky tests on run #3659 ↗︎

0 330 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 jesper-bylund 🗃️ e2e/*
Project: n8n Commit: e505e9a1fa
Status: Passed Duration: 07:06 💡
Started: Jan 9, 2024 9:41 AM Ended: Jan 9, 2024 9:48 AM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8206 ↗︎

Copy link
Contributor

github-actions bot commented Jan 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@krynble krynble force-pushed the pay-1176-improve-hierarchy-of-workflow-executions-view branch from d412ec7 to e505e9a Compare January 9, 2024 09:35
Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ All Cypress E2E specs passed

@krynble krynble merged commit 9d40ae8 into master Jan 9, 2024
19 checks passed
@krynble krynble deleted the pay-1176-improve-hierarchy-of-workflow-executions-view branch January 9, 2024 10:20
MiloradFilipovic added a commit that referenced this pull request Jan 10, 2024
* master:
  ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271)
  fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280)
  fix: Fix issue with API key being required for the Qdrant Node (#8237)
  feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771)
  fix(FTP Node): FTP connection failed due to missing password credential in node (#8131)
  ci: Fix lint setup in `chat` package (no-changelog) (#8275)
  ci: Fix codecov reporting, and include all packages (no-changelog) (#8276)
  fix(core): Fix test webhook deregistration (#8247)
  docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273)
  fix: Fix user reinvites on FE and BE (#8261)
  docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270)
  feat: Add Chat Trigger node (#7409)
  fix(Github Trigger Node): Enforce SSL validation by default (#8265)
  fix(editor): Tweaking button sizes in execution preview (#8206)
  fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants