Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Avoid sanitizing output to search node data #8119

Closed
wants to merge 1 commit into from

Conversation

mutdmour
Copy link
Contributor

Summary

In search feature, output sanitization was added to support <mark tag in output panel to highlight searched text. This removes any html like data in the input/output panel..
This PR removes sanitization while keeping text highlights..

Related tickets and issues

https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
#8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 21, 2023
Copy link

cypress bot commented Dec 21, 2023

1 failed and 1 flaky tests on run #3453 ↗︎

1 258 5 0 Flakiness 1

Details:

🌳 ado-1594 🖥️ browsers:node18.12.0-chrome107 🤖 mutasem 🗃️ e2e/*
Project: n8n Commit: 3152231134
Status: Failed Duration: 06:26 💡
Started: Dec 21, 2023 2:12 PM Ended: Dec 21, 2023 2:19 PM
Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from json view Screenshots Video
Failed  16-form-trigger-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  27-two-factor-authentication.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  15-scheduler-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  29-sql-editor.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 18 specs in Cypress Cloud.

Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video

Review all test suite changes for PR #8119 ↗︎

@mutdmour mutdmour closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant