Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text disappear if between '<' and '>' character #8081

Closed
mbrother2 opened this issue Dec 19, 2023 · 3 comments
Closed

Text disappear if between '<' and '>' character #8081

mbrother2 opened this issue Dec 19, 2023 · 3 comments
Labels
Released

Comments

@mbrother2
Copy link

Describe the bug
Text disappear if between '<' and '>' character

To Reproduce
Steps to reproduce the behavior:

  1. Go to recent execution
  2. Click on any node
  3. Both INPUT and OUTPUT of node will hide all texts are between '<' and '>' character in Table and JSON mode (Schema OK)

Expected behavior
All texts show normally

Environment (please complete the following information):

  • OS: Debian 11
  • n8n Version: 1.20.0
  • Node.js Version: v18.18.2
  • Database system: SQLite
  • Operation mode: Main

Additional context
Please see attachments:

Table Mode (error):
error1_table

JSON Mode (error):
error2_json

Schema Mode (OK):
ok_schema
@janober
Copy link
Member

janober commented Dec 19, 2023

Thanks a lot for reporting this issue. It is already tracked internally via the ticket ID ADO-1594

This was referenced Dec 21, 2023
Closed
Merged
mutdmour added a commit that referenced this issue Dec 22, 2023
@mutdmour
fix(editor): Avoid sanitizing output to search node data (#8126)
c83d9f4 
## Summary
In search feature, output sanitization was added to support `<mark` tag
in output panel to highlight searched text. This removes any html like
data in the input/output panel..
This PR removes sanitization while keeping text highlights..


## Related tickets and issues
https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
#8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue


## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
ivov pushed a commit that referenced this issue Dec 27, 2023
@mutdmour @ivov
fix(editor): Avoid sanitizing output to search node data (#8126)
9a3c133 
In search feature, output sanitization was added to support `<mark` tag
in output panel to highlight searched text. This removes any html like
data in the input/output panel..
This PR removes sanitization while keeping text highlights..

https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
#8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue

- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
@Joffcom
Copy link
Member

Joffcom commented Jan 2, 2024

Hey @mbrother2,

It looks like this should be fixed from 1.22.1 onwards, I am going to mark this as closed if you are still seeing this on newer versions let me know and we can open it again.

@Joffcom Joffcom closed this as completed Jan 2, 2024
@Joffcom
Copy link
Member

Joffcom commented Jan 3, 2024

Fix got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Joffcom @janober @mbrother2