Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): De-duplicate frontend devDependencies (no-changelog) #8094

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 19, 2023

@n8n/chat was pulling in a lot of duplicate dependencies. This PR updates all frontend packages to use an many of the same versions of frontend devDependencies as possible.

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy force-pushed the deduplicate-frontend-dependencies branch from a5dfa95 to 5ba074b Compare December 19, 2023 13:30
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 19, 2023
@netroy netroy force-pushed the deduplicate-frontend-dependencies branch 2 times, most recently from f336b00 to ada5b2a Compare December 19, 2023 14:29
@netroy netroy force-pushed the deduplicate-frontend-dependencies branch from ada5b2a to 0ce4bdc Compare December 19, 2023 14:30
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally, let's see what CI thinks about it :P

Copy link

cypress bot commented Dec 19, 2023

Passing run #3417 ↗︎

0 313 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 0ce4bdce03
Status: Passed Duration: 06:27 💡
Started: Dec 19, 2023 4:36 PM Ended: Dec 19, 2023 4:42 PM

Review all test suite changes for PR #8094 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 3a01550 into master Dec 19, 2023
19 checks passed
@netroy netroy deleted the deduplicate-frontend-dependencies branch December 19, 2023 16:43
MiloradFilipovic added a commit that referenced this pull request Dec 21, 2023
* master: (22 commits)
  fix(editor): Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys (#8024)
  fix(core):  Downgrade Rudderstack SDK (no-changelog) (#8107)
  fix(editor): Move versions check to init function and refactor store (no-changelog) (#8067)
  refactor(editor): Add telemetry for SSO/SAML (no-changelog) (#8102)
  fix(editor): Ensure execution data overrides pinned data when copying in executions view (#8009)
  fix(editor): Fix copy/paste issue when switch node is in workflow (#8103)
  feat(editor): Upgrade frontend tooling to address a few vulnerabilities (#8100)
  feat(editor): De-duplicate frontend devDependencies (no-changelog) (#8094)
  refactor(core): Improve test-webhooks (no-changelog) (#8069)
  refactor: Add telemetry for RBAC (no-changelog) (#8056)
  feat(core): Upgrade Rudderstack SDK (no-changelog) (#8090)
  fix: Upgrade axios to address CVE-2023-45857 (#7713)
  fix(core): Do not display error when stopping jobless execution in queue mode (#8007)
  feat(editor): Gracefully ignore invalid payloads in postMessage handler (#8096)
  feat(editor): Add lead enrichment suggestions to workflow list (#8042)
  refactor(Discord Node): Stop reporting to Sentry inaccessible guild error (no-changelog) (#8095)
  feat: Add opt-in enterprise license trial checkbox (no-changelog) (#7826)
  ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076)
  refactor(editor): Add telemetry for log streaming (no-changelog) (#8075)
  fix(core): Use relative imports for dynamic imports in SecurityAuditService (#8086)
  ...
@janober
Copy link
Member

janober commented Dec 21, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants