Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add telemetry for RBAC (no-changelog) #8056

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 15, 2023

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 15, 2023
krynble
krynble previously approved these changes Dec 18, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be noted with (no-changelog) as it's not really important for users.

packages/cli/src/services/user.service.ts Outdated Show resolved Hide resolved
@ivov ivov changed the title refactor: Add telemetry for RBAC refactor: Add telemetry for RBAC (no-changelog) Dec 18, 2023
Copy link

cypress bot commented Dec 18, 2023

Passing run #3415 ↗︎

0 313 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 4bdcd23781
Status: Passed Duration: 06:59 💡
Started: Dec 19, 2023 3:52 PM Ended: Dec 19, 2023 3:59 PM

Review all test suite changes for PR #8056 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy
Copy link
Member

netroy commented Dec 19, 2023

LGTM, but there is a conflict.

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 38d1336 into master Dec 19, 2023
19 checks passed
@ivov ivov deleted the pay-1142-rbac-telemetry branch December 19, 2023 16:02
MiloradFilipovic added a commit that referenced this pull request Dec 21, 2023
* master: (22 commits)
  fix(editor): Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys (#8024)
  fix(core):  Downgrade Rudderstack SDK (no-changelog) (#8107)
  fix(editor): Move versions check to init function and refactor store (no-changelog) (#8067)
  refactor(editor): Add telemetry for SSO/SAML (no-changelog) (#8102)
  fix(editor): Ensure execution data overrides pinned data when copying in executions view (#8009)
  fix(editor): Fix copy/paste issue when switch node is in workflow (#8103)
  feat(editor): Upgrade frontend tooling to address a few vulnerabilities (#8100)
  feat(editor): De-duplicate frontend devDependencies (no-changelog) (#8094)
  refactor(core): Improve test-webhooks (no-changelog) (#8069)
  refactor: Add telemetry for RBAC (no-changelog) (#8056)
  feat(core): Upgrade Rudderstack SDK (no-changelog) (#8090)
  fix: Upgrade axios to address CVE-2023-45857 (#7713)
  fix(core): Do not display error when stopping jobless execution in queue mode (#8007)
  feat(editor): Gracefully ignore invalid payloads in postMessage handler (#8096)
  feat(editor): Add lead enrichment suggestions to workflow list (#8042)
  refactor(Discord Node): Stop reporting to Sentry inaccessible guild error (no-changelog) (#8095)
  feat: Add opt-in enterprise license trial checkbox (no-changelog) (#7826)
  ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076)
  refactor(editor): Add telemetry for log streaming (no-changelog) (#8075)
  fix(core): Use relative imports for dynamic imports in SecurityAuditService (#8086)
  ...
@janober
Copy link
Member

janober commented Dec 21, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants