Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Qdrant Vector Store Node): Qdrant vector store support #8080

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Dec 19, 2023

Summary

This PR intends to add Qdrant as a supported vectorstore node to load and retrieve documents from in a workflow.

Review / Merge checklist

Sorry, something went wrong.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added the community Authored by a community member label Dec 19, 2023
@Anush008
Copy link
Contributor Author

@netroy, could you please review?

@netroy
Copy link
Member

netroy commented Dec 27, 2023

Thanks for the PR 🙏🏽

@netroy, could you please review?

but please don't mention random repo maintainers like this. It's not helping anyone.

I for one can't really review this particular PR because I'm not familiar with this part of the code.

we'll try to route this issue to the correct maintainers as soon as we can.
Due to holidays, it might take a bit longer than usual.

@netroy
Copy link
Member

netroy commented Dec 27, 2023

This code looks very similar to the stuff @OlegIvaniv is already working on, probably based on #7807.

I really wish that you had created an issue before starting to work on this PR 😞

Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Anush008, I appreciate the work you've done here! There are a few linting issues; please run pnpm lintfix in the packages/@n8n/nodes-langchain directory to fix those automatically.
Other than that, the node works as expected in all three modes. I dropped a few comments about stylistic things that would be nice to improve, and I'd be happy to get this in 🙌.

@Anush008
Copy link
Contributor Author

Anush008 commented Jan 3, 2024

Should be resolved now.
2881e63

P.S. Bumping the docs PR.
n8n-io/n8n-docs#1796

Anush008 and others added 6 commits January 3, 2024 10:34

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…rant/VectorStoreQdrant.node.ts

Co-authored-by: oleg <me@olegivaniv.com>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@netroy netroy force-pushed the qdrant-vector-store branch from 4527306 to bf43a0b Compare January 3, 2024 09:35
@netroy netroy changed the title feat(Qdrant Node): Qdrant vector store support feat(Qdrant Vector Store Node): Qdrant vector store support Jan 3, 2024
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick addressing of the review points, @Anush008! LGTM

@OlegIvaniv OlegIvaniv merged commit 66460f6 into n8n-io:master Jan 3, 2024
7 of 9 checks passed
@Anush008 Anush008 deleted the qdrant-vector-store branch January 3, 2024 10:35
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
ivov added a commit that referenced this pull request Jan 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#
[1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0)
(2024-01-03)


### Bug Fixes

* **Asana Node:** Omit body from GET, HEAD, and DELETE requests
([#8057](#8057))
([15ffd4f](15ffd4f))
* **core:** Better input validation for the changeRole endpoint
([#8189](#8189))
([cfe9525](cfe9525))
* **core:** Fix issue that pinnedData is not used with Test-Webhooks
([#8123](#8123))
([fa8bd8b](fa8bd8b))
* **core:** Handle empty executions table in pruning in migrations
([#8121](#8121))
([ffaa30d](ffaa30d))
* **core:** Remove circular dependency in WorkflowService and
ActiveWorkflowRunner
([#8128](#8128))
([21788d9](21788d9))
* **core:** Use pinned data only for manual mode
([#8164](#8164))
([ea7e76f](ea7e76f))
* **Discord Node:** Remove unnecessary requirement on parameters
([#8060](#8060))
([ef3a577](ef3a577))
* **editor:** Avoid sanitizing output to search node data
([#8126](#8126))
([c83d9f4](c83d9f4))
* **editor:** Enable explicit undo keyboard shortcut across all code
editors ([#8178](#8178))
([cf7f668](cf7f668))
* **editor:** Fix operation change failing in certain conditions
([#8114](#8114))
([711fa2b](711fa2b))
* **editor:** Fix templates view layout
([#8196](#8196))
([d01e42a](d01e42a))
* **editor:** Fix UI urls when hosted behind a path prefix
([#8198](#8198))
([5c078f1](5c078f1))
* **editor:** Prevent browser zoom when scrolling inside sticky edit
mode ([#8116](#8116))
([e928210](e928210))
* **editor:** Prevent canvas undo/redo when NDV is open
([#8118](#8118))
([39e45d8](39e45d8))
* **editor:** Prevent storing pairedItem data inside of pinData
([#8173](#8173))
([405e267](405e267))
* **GitHub Node:** Fix issue that File->Get did not run once per item
([#8190](#8190))
([11cda41](11cda41))
* **Invoice Ninja Node:** Fix issue with custom invoice numbers not
working with v5 ([#8200](#8200))
([3b6ae2d](3b6ae2d))
* **Microsoft Excel 365 Node:** Ensure arg is string during worksheet
table search ([#8154](#8154))
([8e873ca](8e873ca))
* **Notion Node:** Ensure arg is string during page ID extraction
([#8153](#8153))
([e94b8a6](e94b8a6))
* **Redis Trigger Node:** Activating a workflow with a Redis trigger
fails ([#8129](#8129))
([a169b74](a169b74))
* **Schedule Trigger Node:** Use the correct `moment` import
([#8185](#8185))
([17a4e2e](17a4e2e))
* Show public API upgrade CTA when feature is not enabled
([#8109](#8109))
([e9c7fd7](e9c7fd7))


### Features

* **core:** Add closeFunction support to Sub-Nodes
([#7708](#7708))
([bec0fae](bec0fae))
* **core:** Add user.profile.beforeUpdate hook
([#8144](#8144))
([e126ed7](e126ed7))
* **core:** Improvements/overhaul for nodes working with binary data
([#7651](#7651))
([5e16dd4](5e16dd4))
* **core:** Remove discontinued crypto-js
([#8104](#8104))
([01e9a79](01e9a79))
* **core:** Unify application components shutdown
([#8097](#8097))
([3a881be](3a881be))
* **editor:** Add node execution status indicator to output panel
([#8124](#8124))
([ab74bad](ab74bad))
* **editor:** Add template Id to workflow metadata
([#8088](#8088))
([517b050](517b050))
* **Home Assistant Node:** Use the new Home Assistant logo
([#8150](#8150))
([518a99e](518a99e))
* **Qdrant Vector Store Node:** Qdrant vector store support
([#8080](#8080))
([66460f6](66460f6))
* **Wordpress Node:** Add option to ignore error when using self signed
certificates ([#8199](#8199))
([65c8e12](65c8e12))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@Joffcom
Copy link
Member

Joffcom commented Jan 3, 2024

Got released with n8n@1.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants