Add Qdrant vector store and Recursive url for documents #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
OlegIvaniv
requested changes
Nov 29, 2023
Comment on lines
+27
to
+33
| { | ||
| displayName: 'Is Auto Embedded', | ||
| name: 'isAutoEmbedded', | ||
| type: 'boolean', | ||
| default: true, | ||
| description: 'Whether to automatically embed documents when they are added', | ||
| }, |
There was a problem hiding this comment.
This property isn't used anywhere in the code
| }), | ||
| }; | ||
|
|
||
| QdrantVectorStore.fromDocuments(documents, embeddings, qdrantConfig) as Promise<VectorStore>; |
There was a problem hiding this comment.
We've recently did some changes to improve handling of these vector store operations. Could you please merge in latest ai-beta and implement similar error handling as we have for VectorStoreSupabase or VectorStorePinecone? I'm also wondering if we should add an option to create a collection if it's missing. WDYT?
Comment on lines
+2
to
+13
| import { | ||
| NodeConnectionType, | ||
| type IExecuteFunctions, | ||
| type INodeType, | ||
| type INodeTypeDescription, | ||
| type SupplyData, | ||
| } from 'n8n-workflow'; | ||
| import { RecursiveUrlLoader } from 'langchain/document_loaders/web/recursive_url'; | ||
| import type { CharacterTextSplitter } from 'langchain/text_splitter'; | ||
| import { compile } from 'html-to-text'; | ||
| import { logWrapper } from '../../../utils/logWrapper'; | ||
| import { getConnectionHintNoticeField } from '../../../utils/sharedFields'; |
There was a problem hiding this comment.
Could you please extract this node from this PR? We're having an ongoing discussion about document loaders so this one will have to wait a bit before getting merged.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Qdrant Vector Store with same features of others.
Also adds the Recursive url document loader