Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ghost Node): Add support for lexical format #7488

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat(Ghost Node): Add support for lexical format #7488

merged 5 commits into from
Oct 23, 2023

Conversation

mcnaveen
Copy link
Contributor

Why this PR?

  • This PR adds a lexical format to the Ghost node.
  • Recently Ghost moved from mobiledoc to lexical as a main editor.

References:

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (76c0481) 33.55% compared to head (91be672) 33.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7488      +/-   ##
==========================================
- Coverage   33.55%   33.55%   -0.01%     
==========================================
  Files        3398     3398              
  Lines      207582   207593      +11     
  Branches    22425    22424       -1     
==========================================
- Hits        69652    69649       -3     
- Misses     136808   136822      +14     
  Partials     1122     1122
Files Coverage Δ
packages/nodes-base/nodes/Ghost/PostDescription.ts 0.00% <ø> (ø)
packages/nodes-base/nodes/Ghost/Ghost.node.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcnaveen mcnaveen marked this pull request as draft October 22, 2023 06:03
@mcnaveen mcnaveen marked this pull request as ready for review October 22, 2023 06:21
@Joffcom Joffcom changed the title feat(Ghost Node): Add lexical format feat(Ghost Node): Add support for lexical format Oct 22, 2023
@Joffcom
Copy link
Member

Joffcom commented Oct 22, 2023

@mcnaveen did you want to fix the lint errors so we can get this merged? I would be tempted to keep the default as MobileDoc for now as well.

@mcnaveen
Copy link
Contributor Author

Sure sure. Will push the changes asap.

@mcnaveen
Copy link
Contributor Author

Hi @Joffcom Done.

@Joffcom
Copy link
Member

Joffcom commented Oct 22, 2023

Hey @mcnaveen

Perfect, will get that merged shortly,

@Joffcom Joffcom merged commit 7b1973c into n8n-io:master Oct 23, 2023
10 checks passed
@mcnaveen
Copy link
Contributor Author

Finally, they updated the developer documentation. https://ghost.org/docs/admin-api#the-post-object

Any ETA on when this will be released? @netroy @Joffcom

@netroy
Copy link
Member

netroy commented Oct 25, 2023

@mcnaveen This will be released in 1.13.0 later today.

@mcnaveen
Copy link
Contributor Author

Thanks @netroy 🎉

@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
netroy added a commit that referenced this pull request Oct 25, 2023
@github-actions @netroy
🚀 Release 1.13.0 (#7512)
2987587 
# [1.13.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([55c6a1b](55c6a1b))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](#7500))
([6f45298](6f45298))
* **core:** Fix `frontend.settings` external hook execution
([#7496](#7496))
([774fe20](774fe20))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([83762e0](83762e0))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([76c0481](76c0481))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([519680c](519680c))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([3c0a166](3c0a166))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([bc47365](bc47365))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([450e0cc](450e0cc))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([ab6a9bb](ab6a9bb))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](#7467))
([a739245](a739245))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](#7498))
([baecb93](baecb93))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([5c46bb0](5c46bb0))
* **Redis Node:** Fix adding sets data types
([#7444](#7444))
([4e66023](4e66023))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](#7505))
([05e6f2a](05e6f2a))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](#7311))
([647372b](647372b))
* **editor:** Add PH tracking to event
([#7511](#7511))
([c47d27d](c47d27d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](#7113))
([ac814a9](ac814a9))
* **Ghost Node:** Add support for lexical format
([#7488](#7488))
([7b1973c](7b1973c))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](#7386))
([689360e](689360e))

Co-authored-by: netroy <[email protected]>
@janober
Copy link
Member

janober commented Oct 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcnaveen @Joffcom @netroy @janober