feat(Facebook Lead Ads Trigger Node): Add Facebook Lead Ads Trigger Node #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
elsmr
changed the title
n8n-assistant
bot
added
n8n team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7113 +/- ##
==========================================
- Coverage 33.50% 33.45% -0.05%
==========================================
Files 3393 3394 +1
Lines 207375 207157 -218
Branches 22384 22354 -30
==========================================
- Hits 69475 69313 -162
+ Misses 136772 136723 -49
+ Partials 1128 1121 -7
☔ View full report in Codecov by Sentry. |
elsmr
changed the title
…hook exists in FB
|
|
elsmr
force-pushed
the
node-740-facebook-lead-ads
branch
from
33cd129
to
b77247b
Compare
maspio
approved these changes
Oct 20, 2023
Passing run #2528 ↗︎
Details:
Review all test suite changes for PR #7113 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
Merged
netroy
added a commit
that referenced
this pull request
Oct 25, 2023
# [1.13.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.13.0) (2023-10-25) ### Bug Fixes * **core:** Do not return `inviteAcceptUrl` in response if email was sent ([#7465](#7465)) ([55c6a1b](55c6a1b)) * **core:** Ensure nodes post-processors run in the correct order ([#7500](#7500)) ([6f45298](6f45298)) * **core:** Fix `frontend.settings` external hook execution ([#7496](#7496)) ([774fe20](774fe20)) * **core:** Handle gzip and deflate compressed request payloads ([#7461](#7461)) ([83762e0](83762e0)) * **core:** Reduce logging overhead for levels that do not output ([#7479](#7479)) ([76c0481](76c0481)) * **Customer.io Node:** Fix api endpoint when using EU region ([#7485](#7485)) ([519680c](519680c)) * **editor:** Allow importing the same workflow multiple times ([#7458](#7458)) ([3c0a166](3c0a166)) * **editor:** Fix canvas selection breaking after interacting with node actions ([#7466](#7466)) ([bc47365](bc47365)) * **editor:** Fix connections disappearing after reactivating canvas and renaming a node ([#7483](#7483)) ([450e0cc](450e0cc)) * **Google Sheets Node:** Append or update runs forever when without column headers ([#7463](#7463)) ([ab6a9bb](ab6a9bb)) * **Microsoft SQL Node:** Prevent SQL injection ([#7467](#7467)) ([a739245](a739245)) * **MQTT Trigger Node:** Fix node causing a start up hang when active ([#7498](#7498)) ([baecb93](baecb93)) * **MySQL Node:** Resolve expressions in v1 ([#7464](#7464)) ([5c46bb0](5c46bb0)) * **Redis Node:** Fix adding sets data types ([#7444](#7444)) ([4e66023](4e66023)) * **Spreadsheet File Node:** Fix include empty cells not working with v2 ([#7505](#7505)) ([05e6f2a](05e6f2a)) ### Features * **core:** Add support for oauth based service accounts with UM SMTP ([#7311](#7311)) ([647372b](647372b)) * **editor:** Add PH tracking to event ([#7511](#7511)) ([c47d27d](c47d27d)) * **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node ([#7113](#7113)) ([ac814a9](ac814a9)) * **Ghost Node:** Add support for lexical format ([#7488](#7488)) ([7b1973c](7b1973c)) * **RSS Feed Trigger Node:** Add RSS feed trigger node ([#7386](#7386)) ([689360e](689360e)) Co-authored-by: netroy <[email protected]>
|
Got released with |
netroy
reviewed
Nov 22, 2023
| @@ -94,7 +94,7 @@ export default defineComponent({ | |||
| } | |||
|
|
|||
| return (this.nodeType as INodeTypeDescription).webhooks!.filter( | |||
| (webhookData) => webhookData.restartWebhook !== true, | |||
| (webhookData) => webhookData.restartWebhook !== true && !webhookData.hasLifecycleMethods, | |||
There was a problem hiding this comment.
@elsmr just FYI: we've reverted this check in #7783
For more context: Slack thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/facebook-lead-ads-integration/4590/19