Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) #7406

Merged
merged 10 commits into from
Oct 19, 2023
Merged

feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) #7406

merged 10 commits into from
Oct 19, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (8212969) 33.51% compared to head (748a1f5) 33.53%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7406      +/-   ##
==========================================
+ Coverage   33.51%   33.53%   +0.02%     
==========================================
  Files        3393     3393              
  Lines      207412   207403       -9     
  Branches    22387    22399      +12     
==========================================
+ Hits        69508    69551      +43     
+ Misses     136782   136731      -51     
+ Partials     1122     1121       -1
Files Coverage Δ
...ponents/WorkflowHistory/WorkflowHistoryContent.vue 99.44% <100.00%> (+3.37%) ⬆️
packages/editor-ui/src/views/WorkflowHistory.vue 72.35% <0.00%> (ø)
...ages/editor-ui/src/stores/workflowHistory.store.ts 45.71% <0.00%> (+0.85%) ⬆️
...kages/editor-ui/src/components/WorkflowPreview.vue 82.11% <75.58%> (+22.66%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krynble
krynble reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a new component, can we add a test to make sure that pinData is removed?

@cstuncsik cstuncsik requested a review from ivov October 13, 2023 14:58
ivov
ivov previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing everything!

@cstuncsik cstuncsik removed the request for review from krynble October 19, 2023 11:55
@cypress
Copy link

cypress bot commented Oct 19, 2023 •
edited
Loading

1 flaky test on run #2519 ↗︎

0 255 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 748a1f5fd2
Status: Passed Duration: 09:20 💡
Started: Oct 19, 2023 12:22 PM Ended: Oct 19, 2023 12:31 PM
Flakiness  cypress/e2e/4-node-creator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Node Creator > should have most relevenat nodes on top when searching Output Screenshots Video

Review all test suite changes for PR #7406 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik
Merge remote-tracking branch 'origin/master' into pay-889-pin-data-ap…
748a1f5 
…plied-incorrectly

# Conflicts:
#	packages/editor-ui/src/views/WorkflowHistory.vue
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit c7c8048 into master Oct 19, 2023
55 of 56 checks passed
@cstuncsik cstuncsik deleted the pay-889-pin-data-applied-incorrectly branch October 19, 2023 12:38
MiloradFilipovic added a commit that referenced this pull request Oct 19, 2023
@MiloradFilipovic
Merge branch 'master' into ado-1225-fix-selection-after-drag
241c582 
* master:
  refactor(core): Make executions pruning settings configurable (#7468)
  feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406)
  feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405)
  fix(core): Do not return `inviteAcceptUrl` in response if email was sent (#7465)
  fix(Google Sheets Node): Append or update runs forever when without column headers (#7463)
@janober
Copy link
Member

janober commented Oct 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble left review comments

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cstuncsik @janober @krynble @ivov