feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7405 +/- ##
==========================================
+ Coverage 33.50% 33.51% +0.01%
==========================================
Files 3389 3389
Lines 207020 207044 +24
Branches 22337 22340 +3
==========================================
+ Hits 69361 69401 +40
+ Misses 136538 136522 -16
Partials 1121 1121
☔ View full report in Codecov by Sentry. |
ivov
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Code looks great! Findings:
- Cloned workflow is missing pinned data and tags. Not sure if intended.
- Cloned workflow should have same version history as original workflow up to this point? It's rather confusing to see no versions when looking at the resulting workflow.
- Cloning a workflow twice (in a row, or after a while) triggers this error. I'd expect us to handle it like workflow duplication.
- Cloning a cloned workflow results in weird naming.
- Cloning an active workflow deactivates the copy. Maybe we should clarify.
- Toast for
Successfully cloned workflow versiondoes not clear when navigating away. Not sure if intended.
|
Fixed number 3. the rest are more like design question (either graphic or functional) |
ivov
approved these changes
Oct 19, 2023
Passing run #2517 ↗︎
Details:
Review all test suite changes for PR #7405 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Oct 19, 2023
* master: refactor(core): Make executions pruning settings configurable (#7468) feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406) feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405) fix(core): Do not return `inviteAcceptUrl` in response if email was sent (#7465) fix(Google Sheets Node): Append or update runs forever when without column headers (#7463)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.