Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix error on missing paired item data #7399

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(core): Fix error on missing paired item data #7399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/workflow/src/WorkflowDataProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ export class WorkflowDataProxy {
' <a target="_blank" href="https://docs.n8n.io/data/data-mapping/data-item-linking/item-linking-errors/">More info</a>';

context.description += moreInfoLink;
context.descriptionTemplate += moreInfoLink;
if (context.descriptionTemplate) context.descriptionTemplate += moreInfoLink;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell testing this would require mocking nodes, connections, node types, and finding a way to check the paired error message on the last node. Since this is only unblocking an error message string, I assume all this setup for a minimal test is not worth the effort. Else let me know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test might be okay just to have something..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I try to avoid adding more to e2e when the issue should be testable via unit tests like here. Ideally the paired item functionality should have a setup for this already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have good paired item e2e tests for mapping data.. but I don't think we have any tests for errors

}
}

Expand Down
Loading