fix(core): Fix error on missing paired item data #7399

ivov · 2023-10-11T08:07:40Z

github-actions · 2023-10-11T08:07:56Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

ivov · 2023-10-11T08:08:37Z

packages/workflow/src/WorkflowDataProxy.ts

@@ -699,7 +699,7 @@ export class WorkflowDataProxy {
 						' <a target="_blank" href="https://docs.n8n.io/data/data-mapping/data-item-linking/item-linking-errors/">More info</a>';

 					context.description += moreInfoLink;
-					context.descriptionTemplate += moreInfoLink;
+					if (context.descriptionTemplate) context.descriptionTemplate += moreInfoLink;


From what I can tell testing this would require mocking nodes, connections, node types, and finding a way to check the paired error message on the last node. Since this is only unblocking an error message string, I assume all this setup for a minimal test is not worth the effort. Else let me know.

e2e test might be okay just to have something..

Thanks, I try to avoid adding more to e2e when the issue should be testable via unit tests like here. Ideally the paired item functionality should have a setup for this already.

we already have good paired item e2e tests for mapping data.. but I don't think we have any tests for errors

codecov · 2023-10-11T08:29:34Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e2c3c7a) 33.43% compared to head (93f5e28) 33.43%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7399   +/-   ##
=======================================
  Coverage   33.43%   33.43%           
=======================================
  Files        3389     3389           
  Lines      206777   206777           
  Branches    22315    22313    -2     
=======================================
+ Hits        69131    69134    +3     
+ Misses     136526   136523    -3     
  Partials     1120     1120

Files	Coverage Δ
packages/workflow/src/WorkflowDataProxy.ts	`46.29% <0.00%> (ø)`

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cypress · 2023-10-11T08:42:26Z

2 flaky tests on run #2464 ↗︎

0	251	0	0	2

Details:

🌳 pay-636-bug-paired-item-errors-are-broken 🖥️ browsers:node18.12.0-chrome107 ...
Project: n8n	Commit: `93f5e28e47`
Status: Passed	Duration: 08:26 💡
Started: Oct 11, 2023 8:33 AM	Ended: Oct 11, 2023 8:42 AM

14-mapping.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Data mapping > shows you can drop to inputs, including booleans		`Output` `Screenshots` `Video`

27-two-factor-authentication.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Two-factor authentication > Should be able to login with MFA token		`Output` `Screenshots` `Video`

Review all test suite changes for PR #7399 ↗︎

github-actions · 2023-10-11T08:42:29Z

✅ All Cypress E2E specs passed

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <[email protected]>

janober · 2023-10-11T13:57:20Z

Got released with [email protected]

* master: fix(core): Fix ignoring crashed executions without event msgs (#7368) ci: Enable ARM64 builds for beta images (no-changelog) (#7403) 🚀 Release 1.11.0 (#7402) fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400) fix(core): Fix error on missing paired item data (#7399) feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378) feat(Item Lists Node): Split merge binary data (#7297) fix(core): Missing pairing info (#7326) fix(Webhook Node): Backward compatible form-data parsing for non-array files (#7385)

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <[email protected]>

fix(core): Fix error on missing paired item data

93f5e28

ivov commented Oct 11, 2023

View reviewed changes

mutdmour approved these changes Oct 11, 2023

View reviewed changes

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 11, 2023

ivov merged commit 47e8953 into master Oct 11, 2023
60 of 61 checks passed

ivov deleted the pay-636-bug-paired-item-errors-are-broken branch October 11, 2023 09:34

github-actions bot mentioned this pull request Oct 11, 2023

🚀 Release 1.11.0 #7402

Merged

janober added the Released label Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Fix error on missing paired item data #7399

fix(core): Fix error on missing paired item data #7399

ivov commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

ivov Oct 11, 2023

mutdmour Oct 11, 2023

ivov Oct 11, 2023

mutdmour Oct 11, 2023

codecov bot commented Oct 11, 2023 •

edited

Loading

cypress bot commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

janober commented Oct 11, 2023

fix(core): Fix error on missing paired item data #7399

fix(core): Fix error on missing paired item data #7399

Conversation

ivov commented Oct 11, 2023

github-actions bot commented Oct 11, 2023

ivov Oct 11, 2023

Choose a reason for hiding this comment

mutdmour Oct 11, 2023

Choose a reason for hiding this comment

ivov Oct 11, 2023

Choose a reason for hiding this comment

mutdmour Oct 11, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 11, 2023 • edited Loading

Codecov Report

cypress bot commented Oct 11, 2023

2 flaky tests on run #2464 ↗︎

Review all test suite changes for PR #7399 ↗︎

github-actions bot commented Oct 11, 2023

janober commented Oct 11, 2023

codecov bot commented Oct 11, 2023 •

edited

Loading