Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add plan name to telemetry (no-changelog) #7296

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Sep 28, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0bc33b1) 33.04% compared to head (a3ca2d2) 33.04%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7296   +/-   ##
=======================================
  Coverage   33.04%   33.04%           
=======================================
  Files        3360     3360           
  Lines      200366   200366           
  Branches    22002    21996    -6     
=======================================
  Hits        66204    66204           
  Misses     133052   133052           
  Partials     1110     1110           
Files Coverage Δ
packages/cli/src/Interfaces.ts 100.00% <ø> (ø)
packages/cli/src/InternalHooks.ts 8.52% <ø> (+2.69%) ⬆️
packages/cli/src/Server.ts 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krynble krynble marked this pull request as draft September 28, 2023 15:00
@krynble krynble marked this pull request as ready for review September 29, 2023 12:37
@cypress
Copy link

cypress bot commented Sep 29, 2023

Passing run #2326 ↗︎

0 242 3 0 Flakiness 0

Details:

🌳 add-plan-name-to-identify 🖥️ browsers:node18.12.0-chrome107 🤖 krynble 🗃️ e...
Project: n8n Commit: a3ca2d2b67
Status: Passed Duration: 09:18 💡
Started: Sep 29, 2023 1:22 PM Ended: Sep 29, 2023 1:32 PM

Review all test suite changes for PR #7296 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@krynble krynble merged commit ec03793 into master Sep 29, 2023
18 checks passed
@krynble krynble deleted the add-plan-name-to-identify branch September 29, 2023 13:41
MiloradFilipovic added a commit that referenced this pull request Oct 2, 2023
* master:
  fix(editor): Separate cloud endpoint calls (#7312)
  fix(core): Account for itemless case on restoring binary data ID (#7305)
  feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186)
  feat(core): Add plan name to telemetry (no-changelog) (#7296)
  ci: Fix typescript incremental builds (no-changelog) (#7275)
  fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
  fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176)
  🚀 Release 1.9.0 (#7288)
  ci: Refactor DB tests (no-changelog) (#7292)
  fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293)
  fix(Respond to Webhook Node): JSON output from expression fix (#7294)
  feat(core): Add secrets provider reload and refactor (#7277)
@janober
Copy link
Member

janober commented Oct 11, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants