ci: Refactor DB tests (no-changelog) #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7292 +/- ##
==========================================
- Coverage 33.04% 33.03% -0.01%
==========================================
Files 3360 3360
Lines 200366 200366
Branches 22002 21997 -5
==========================================
- Hits 66204 66197 -7
- Misses 133052 133059 +7
Partials 1110 1110 ☔ View full report in Codecov by Sentry. |
netroy
changed the title
krynble
previously approved these changes
Sep 28, 2023
Passing run #2314 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
force-pushed
the
reduce-mysql-ci-memory-usage
branch
from
482e629
to
27eba32
Compare
netroy
changed the title
netroy
commented
Sep 28, 2023
| @@ -124,12 +124,10 @@ describe('POST /credentials', () => { | |||
| }); | |||
|
|
|||
| test('should fail with invalid inputs', async () => { | |||
| await Promise.all( | |||
There was a problem hiding this comment.
using await Promise.all( is somehow causing DB connection resets, leading to failing tests.
Not sure why that is, but switched to a for loop to unblock the CI.
krynble
approved these changes
Sep 28, 2023
|
✅ All Cypress E2E specs passed |
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Oct 2, 2023
* master: fix(editor): Separate cloud endpoint calls (#7312) fix(core): Account for itemless case on restoring binary data ID (#7305) feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186) feat(core): Add plan name to telemetry (no-changelog) (#7296) ci: Fix typescript incremental builds (no-changelog) (#7275) fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300) fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176) 🚀 Release 1.9.0 (#7288) ci: Refactor DB tests (no-changelog) (#7292) fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293) fix(Respond to Webhook Node): JSON output from expression fix (#7294) feat(core): Add secrets provider reload and refactor (#7277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB tests