Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure new Set node is on top of search list #7215

Merged
merged 5 commits into from
Sep 20, 2023
Merged

fix: Ensure new Set node is on top of search list #7215

merged 5 commits into from
Sep 20, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 63.21% and project coverage change: +0.03% 🎉

Comparison is base (cf776b8) 32.65% compared to head (c452378) 32.69%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7215      +/-   ##
==========================================
+ Coverage   32.65%   32.69%   +0.03%     
==========================================
  Files        3340     3346       +6     
  Lines      199463   199748     +285     
  Branches    21850    21889      +39     
==========================================
+ Hits        65133    65298     +165     
- Misses     133250   133355     +105     
- Partials     1080     1095      +15     
Files Changed Coverage Δ
packages/cli/src/License.ts 51.75% <ø> (ø)
...es/editor-ui/src/components/ParameterInputList.vue 54.66% <0.00%> (-0.31%) ⬇️
...des/Code/descriptions/JavascriptCodeDescription.ts 100.00% <ø> (ø)
...e/nodes/Code/descriptions/PythonCodeDescription.ts 100.00% <ø> (ø)
packages/nodes-base/nodes/CrateDb/CrateDb.node.ts 0.00% <ø> (ø)
...uery/v2/actions/database/executeQuery.operation.ts 41.89% <ø> (ø)
...odes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/MySql/v1/MySqlV1.node.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Postgres/v1/PostgresV1.node.ts 0.00% <ø> (ø)
...ges/nodes-base/nodes/Postgres/v2/actions/router.ts 0.00% <0.00%> (ø)
... and 22 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Nice test coverage 🙌

@cypress
Copy link

cypress bot commented Sep 20, 2023

Passing run #2226 ↗︎

0 235 3 0 Flakiness 0

Details:

🌳 ado-1110 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: c4523782ea
Status: Passed Duration: 08:08 💡
Started: Sep 20, 2023 2:05 PM Ended: Sep 20, 2023 2:13 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 2491ccf into master Sep 20, 2023
18 checks passed
@mutdmour mutdmour deleted the ado-1110 branch September 20, 2023 14:47
netroy pushed a commit that referenced this pull request Sep 21, 2023
Github issue / Community forum post (link here to close automatically):
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
netroy added a commit that referenced this pull request Sep 21, 2023
## [1.8.1](https://github.com/n8n-io/n8n/compare/[email protected]@1.8.1)
(2023-09-21)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([ebfcc87](ebfcc87))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([fb36b0a](fb36b0a))
* Ensure new Set node is on top of search list
([#7215](#7215))
([c8fb06f](c8fb06f))
* Issue enforcing user limits on start plan
([#7188](#7188))
([50a4c5e](50a4c5e))


### Reverts

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([6ac19a5](6ac19a5))

Co-authored-by: netroy <[email protected]>
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with [email protected]

This was referenced Sep 27, 2023
netroy added a commit that referenced this pull request Sep 28, 2023
# [1.9.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.9.0)
(2023-09-28)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([2af967c](2af967c))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282](#7282))
([a80abad](a80abad))
* **core:** Fix binary data manager check on pruning
([#7251](#7251))
([484035e](484035e))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244](#7244))
([33991e9](33991e9))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([67b985f](67b985f))
* **core:** Make DNS resolution order configurable
([#7272](#7272))
([5b3121c](5b3121c))
* **core:** Make senderId required for all command messages
([#7252](#7252))
([4b01428](4b01428))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261](#7261))
([861cac5](861cac5))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948](#6948))
([0132514](0132514)),
closes [#2178](#2178)
[#2810](#2810)
[#3855](#3855)
[#2813](#2813)
* **editor:** Add debug feature docs link
([#7240](#7240))
([4614e1e](4614e1e))
* **editor:** Fix SQL editor issue
([#7236](#7236))
([647fc6c](647fc6c))
* **editor:** Ensure new Set node is on top of search list
([#7215](#7215))
([2491ccf](2491ccf))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](#7188)
([303bc8e](303bc8e))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293](#7293))
([0bc33b1](0bc33b1))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286](#7286))
([cde23a1](cde23a1))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294](#7294))
([8bc369d](8bc369d))


### Features

* Add onboarding flow
([#7212](#7212))
([01e9340](01e9340))
* **core:** Add secrets provider reload and refactor
([#7277](#7277))
([53a7502](53a7502))
* **core:** Add Tournament as the new default expression evaluator
([#6964](#6964))
([bf74f09](bf74f09))
* **core:** Initial workflow history API
([#7234](#7234))
([0083a9e](0083a9e))
* **core:** Introduce object store service
([#7225](#7225))
([fa84545](fa84545))
* **editor:** Add user cloud ID to telemetry
[#7232](#7232)
([60c152d](60c152d))
* **editor:** Rework banners framework and add email confirmation banner
([#7205](#7205))
([b0e98b5](b0e98b5))
* **MISP Node:** Update credential to support HTTP Request node
([#7268](#7268))
([e4c302c](e4c302c))


### Performance Improvements

* **core:** Skip unneeded calls on every pruning cycle
([#7260](#7260))
([db01164](db01164))

Co-authored-by: netroy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants