fix(core): Handle filename* with quotes in Content-Disposition header (…

…#7229) Github issue / Community forum post (link here to close automatically):
n8n-io · Sep 21, 2023 · fb36b0a · fb36b0a
1 parent ebfcc87
commit fb36b0a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts
@@ -649,7 +649,7 @@ function parseFileName(filename?: string): string | undefined {
 
 // https://datatracker.ietf.org/doc/html/rfc5987
 function parseFileNameStar(filename?: string): string | undefined {
-	const [_encoding, _locale, content] = filename?.split("'") ?? [];
+	const [_encoding, _locale, content] = parseFileName(filename)?.split("'") ?? [];
 
 	return content;
 }

diff --git a/packages/core/test/NodeExecuteFunctions.test.ts b/packages/core/test/NodeExecuteFunctions.test.ts
@@ -176,6 +176,21 @@ describe('NodeExecuteFunctions', () => {
 			});
 		});
 
+		it('parses valid content-disposition header with filename* (quoted)', () => {
+			const message = mock<IncomingMessage>({
+				headers: {
+					'content-type': undefined,
+					'content-disposition': ' attachment;filename*="utf-8\' \'test-unsplash.jpg"',
+				},
+			});
+			parseIncomingMessage(message);
+
+			expect(message.contentDisposition).toEqual({
+				filename: 'test-unsplash.jpg',
+				type: 'attachment',
+			});
+		});
+
 		it('parses valid content-disposition header with filename and trailing ";"', () => {
 			const message = mock<IncomingMessage>({
 				headers: {