feat(Matrix Node): Allow setting filename if the binary data has none #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6536 +/- ##
==========================================
- Coverage 28.72% 28.65% -0.07%
==========================================
Files 3000 3000
Lines 186302 186303 +1
Branches 20600 20600
==========================================
- Hits 53517 53387 -130
- Misses 131978 132106 +128
- Partials 807 810 +3
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
maspio
approved these changes
Jun 23, 2023
maspio
approved these changes
Jun 23, 2023
1 flaky tests on run #1316 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Schedule Trigger node > should execute once per second when activated |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
1 similar comment
|
✅ All Cypress E2E specs passed |
netroy
added a commit
to netroy/n8n
that referenced
this pull request
Jun 27, 2023
# [1.0.0](https://github.com/netroy/n8n/compare/[email protected]@1.0.0) (2023-06-27) ### Bug Fixes * **core:** Add empty credential value marker to show empty pw field ([n8n-io#6532](https://github.com/netroy/n8n/issues/6532)) ([9294e2d](9294e2d)) * **core:** All migrations should run in a transaction ([n8n-io#6519](https://github.com/netroy/n8n/issues/6519)) ([e152cfe](e152cfe)) * **core:** Rename to credential_stubs and variable_stubs.json ([n8n-io#6528](https://github.com/netroy/n8n/issues/6528)) ([b06462f](b06462f)) * **Edit Image Node:** Fix transparent operation ([n8n-io#6513](https://github.com/netroy/n8n/issues/6513)) ([4a4bcbc](4a4bcbc)) * **editor:** Add default author name and email to source control settings ([n8n-io#6543](https://github.com/netroy/n8n/issues/6543)) ([e1a02c7](e1a02c7)) * **editor:** Change default branchColor and remove label ([n8n-io#6541](https://github.com/netroy/n8n/issues/6541)) ([186271e](186271e)) * **Google Drive Node:** URL parsing ([n8n-io#6527](https://github.com/netroy/n8n/issues/6527)) ([d9ed0b3](d9ed0b3)) * **Google Sheets Node:** Incorrect read of 0 and false ([n8n-io#6525](https://github.com/netroy/n8n/issues/6525)) ([806d134](806d134)) * **Merge Node:** Enrich input 2 fix ([n8n-io#6526](https://github.com/netroy/n8n/issues/6526)) ([c82c7f1](c82c7f1)) * **Notion Node:** Version fix ([n8n-io#6531](https://github.com/netroy/n8n/issues/6531)) ([38dc784](38dc784)) ### Features * Add missing input panels to some trigger nodes ([n8n-io#6518](https://github.com/netroy/n8n/issues/6518)) ([fdf8a42](fdf8a42)) * **editor:** Prevent saving of workflow when canvas is loading ([n8n-io#6497](https://github.com/netroy/n8n/issues/6497)) ([f89ef83](f89ef83)) * **editor:** SQL editor overhaul ([n8n-io#6282](https://github.com/netroy/n8n/issues/6282)) ([beedfb6](beedfb6)) * **Google Drive Node:** Overhaul ([n8n-io#5941](https://github.com/netroy/n8n/issues/5941)) ([d70a1cb](d70a1cb)) * **HTTP Request Node:** Notice about dev console ([n8n-io#6516](https://github.com/netroy/n8n/issues/6516)) ([d431117](d431117)) * **Matrix Node:** Allow setting filename if the binary data has none ([n8n-io#6536](https://github.com/netroy/n8n/issues/6536)) ([8b76e98](8b76e98)) Co-authored-by: netroy <[email protected]>
Merged
Closed
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically): #6534