Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Edit Image Node): Fix transparent operation #6513

Merged

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Jun 22, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/edit-image-transparent-issues/19690

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (f32d5f6) 28.51% compared to head (923b00a) 28.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6513      +/-   ##
==========================================
- Coverage   28.51%   28.44%   -0.08%     
==========================================
  Files        3000     3000              
  Lines      186127   186127              
  Branches    20529    20526       -3     
==========================================
- Hits        53075    52944     -131     
- Misses     132245   132376     +131     
  Partials      807      807              
Impacted Files Coverage Δ
...kages/nodes-base/nodes/EditImage/EditImage.node.ts 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 22, 2023

2 flaky tests on run #1290 ↗︎

0 227 0 0 Flakiness 2

Details:

🌳 node-13-edit-image-node-bug-operation-transparent-not-working 🖥️ browsers:no...
Project: n8n Commit: 923b00a9d9
Status: Passed Duration: 07:12 💡
Started: Jun 22, 2023 2:48 PM Ended: Jun 22, 2023 2:55 PM
Flakiness  16-webhook-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Webhook Trigger node > should listen for a GET request Output Screenshots Video
Flakiness  18-user-management.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Management > should delete user and their data Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@maspio maspio merged commit 4a4bcbc into master Jun 22, 2023
@maspio maspio deleted the node-13-edit-image-node-bug-operation-transparent-not-working branch June 22, 2023 15:46
netroy added a commit to netroy/n8n that referenced this pull request Jun 27, 2023
# [1.0.0](https://github.com/netroy/n8n/compare/[email protected]@1.0.0)
(2023-06-27)


### Bug Fixes

* **core:** Add empty credential value marker to show empty pw field
([n8n-io#6532](https://github.com/netroy/n8n/issues/6532))
([9294e2d](9294e2d))
* **core:** All migrations should run in a transaction
([n8n-io#6519](https://github.com/netroy/n8n/issues/6519))
([e152cfe](e152cfe))
* **core:** Rename to credential_stubs and variable_stubs.json
([n8n-io#6528](https://github.com/netroy/n8n/issues/6528))
([b06462f](b06462f))
* **Edit Image Node:** Fix transparent operation
([n8n-io#6513](https://github.com/netroy/n8n/issues/6513))
([4a4bcbc](4a4bcbc))
* **editor:** Add default author name and email to source control
settings ([n8n-io#6543](https://github.com/netroy/n8n/issues/6543))
([e1a02c7](e1a02c7))
* **editor:** Change default branchColor and remove label
([n8n-io#6541](https://github.com/netroy/n8n/issues/6541))
([186271e](186271e))
* **Google Drive Node:** URL parsing
([n8n-io#6527](https://github.com/netroy/n8n/issues/6527))
([d9ed0b3](d9ed0b3))
* **Google Sheets Node:** Incorrect read of 0 and false
([n8n-io#6525](https://github.com/netroy/n8n/issues/6525))
([806d134](806d134))
* **Merge Node:** Enrich input 2 fix
([n8n-io#6526](https://github.com/netroy/n8n/issues/6526))
([c82c7f1](c82c7f1))
* **Notion Node:** Version fix
([n8n-io#6531](https://github.com/netroy/n8n/issues/6531))
([38dc784](38dc784))


### Features

* Add missing input panels to some trigger nodes
([n8n-io#6518](https://github.com/netroy/n8n/issues/6518))
([fdf8a42](fdf8a42))
* **editor:** Prevent saving of workflow when canvas is loading
([n8n-io#6497](https://github.com/netroy/n8n/issues/6497))
([f89ef83](f89ef83))
* **editor:** SQL editor overhaul
([n8n-io#6282](https://github.com/netroy/n8n/issues/6282))
([beedfb6](beedfb6))
* **Google Drive Node:** Overhaul
([n8n-io#5941](https://github.com/netroy/n8n/issues/5941))
([d70a1cb](d70a1cb))
* **HTTP Request Node:** Notice about dev console
([n8n-io#6516](https://github.com/netroy/n8n/issues/6516))
([d431117](d431117))
* **Matrix Node:** Allow setting filename if the binary data has none
([n8n-io#6536](https://github.com/netroy/n8n/issues/6536))
([8b76e98](8b76e98))

Co-authored-by: netroy <[email protected]>
This was referenced Jun 27, 2023
netroy pushed a commit that referenced this pull request Jul 5, 2023
This was referenced Jul 5, 2023
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants