fix(Zendesk Node): Fix issue with group assignment not working #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6501 +/- ##
==========================================
- Coverage 28.51% 28.43% -0.08%
==========================================
Files 3000 3000
Lines 186129 186129
Branches 20530 20526 -4
==========================================
- Hits 53066 52935 -131
- Misses 132257 132388 +131
Partials 806 806
☔ View full report in Codecov by Sentry. |
maspio
approved these changes
Jun 21, 2023
2 flaky tests on run #1276 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo multiple steps |
Output
Screenshots
Video
|
|
14-mapping.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data mapping > shows you can drop to inputs, including booleans |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 22, 2023
* master: fix(core): Fix the `db:revert` command (no-changelog) (#6506) fix(core): Add additional path-traversal guards on res.sendFile calls (no-changelog) (#6505) fix(Zendesk Node): Fix issue with group assignment not working (#6501) fix: Make MySQL migration for nano id change compatible with version 5.7 (#6498) fix(core): Use correct scopes-separator when generating authorization urls (#6502) feat(core): Add GET /users endpoints to public API (#6360) fix(core): Fix OAuth2 callback for `grantType=clientCredentials` (#6500) docs(DebugHelper Node): Update codex for debughelper (no-changelog) (#6499) feat(core): Add PKCE for OAuth2 (#6324) fix(core): Fix pairedItem for alwaysOutputData & multi identical resolve (#6405) feat: Migrate integer primary keys to nanoids (#6345) fix(editor): Fix resource mapper dropdown width and disabled styling (#6493) fix(core): Improve the error returned to users on SSL issues (#6494) fix(HTTP Request Node): "Ignore SSL issues" should also ignore legacy renegotiation issues (#6492) feat(Stripe Trigger Node): Add action required trigger for payment intents (#6490) build: Check test files (#6455)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically): #6491