Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DebugHelper Node): Update codex for debughelper (no-changelog) #6499

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jun 21, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 5.88% and project coverage change: -0.08 ⚠️

Comparison is base (4b0e0b7) 28.50% compared to head (1828dc9) 28.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6499      +/-   ##
==========================================
- Coverage   28.50%   28.42%   -0.08%     
==========================================
  Files        2998     2999       +1     
  Lines      186066   186082      +16     
  Branches    20524    20524              
==========================================
- Hits        53029    52899     -130     
- Misses     132232   132378     +146     
  Partials      805      805              
Impacted Files Coverage Δ
...ckages/cli/src/credentials/oauth2Credential.api.ts 0.00% <0.00%> (ø)
packages/core/src/NodeExecuteFunctions.ts 17.42% <ø> (ø)
...i/src/components/CredentialEdit/CredentialEdit.vue 0.00% <0.00%> (ø)
...-base/credentials/AirtableOAuth2Api.credentials.ts 0.00% <0.00%> (ø)
...es/nodes-base/credentials/OAuth2Api.credentials.ts 0.00% <ø> (ø)
...ackages/nodes-base/nodes/Airtable/Airtable.node.ts 17.12% <ø> (ø)
packages/workflow/src/Interfaces.ts 53.84% <100.00%> (+3.84%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 21, 2023

Passing run #1268 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 update/debughelper 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 1828dc9173
Status: Passed Duration: 07:05 💡
Started: Jun 21, 2023 9:30 AM Ended: Jun 21, 2023 9:37 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 1cf36e1 into master Jun 21, 2023
@Joffcom Joffcom deleted the update/debughelper branch June 21, 2023 09:53
MiloradFilipovic added a commit that referenced this pull request Jun 22, 2023
* master:
  fix(core): Fix the `db:revert` command (no-changelog) (#6506)
  fix(core): Add additional path-traversal guards on res.sendFile calls (no-changelog) (#6505)
  fix(Zendesk Node): Fix issue with group assignment not working (#6501)
  fix: Make MySQL migration for nano id change compatible with version 5.7 (#6498)
  fix(core): Use correct scopes-separator when generating authorization urls (#6502)
  feat(core): Add GET /users endpoints to public API (#6360)
  fix(core): Fix OAuth2 callback for `grantType=clientCredentials` (#6500)
  docs(DebugHelper Node): Update codex for debughelper (no-changelog) (#6499)
  feat(core): Add PKCE for OAuth2 (#6324)
  fix(core): Fix pairedItem for alwaysOutputData & multi identical resolve (#6405)
  feat: Migrate integer primary keys to nanoids (#6345)
  fix(editor): Fix resource mapper dropdown width and disabled styling (#6493)
  fix(core): Improve the error returned to users on SSL issues (#6494)
  fix(HTTP Request Node): "Ignore SSL issues" should also ignore legacy renegotiation issues (#6492)
  feat(Stripe Trigger Node): Add action required trigger for payment intents (#6490)
  build: Check test files (#6455)
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants