Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gmail Node): Add reply to email #6453

Merged
merged 11 commits into from
Jun 16, 2023

Conversation

michael-radency
Copy link
Contributor

original PR: #4414
contributor: @feelgood-interface

@michael-radency michael-radency added node/improvement New feature or request community Authored by a community member labels Jun 16, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@michael-radency michael-radency changed the title fix(Gmail Node): Add reply to email feat(Gmail Node): Add reply to email Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.07 ⚠️

Comparison is base (bbe4938) 28.44% compared to head (dfaeb03) 28.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6453      +/-   ##
==========================================
- Coverage   28.44%   28.37%   -0.07%     
==========================================
  Files        2991     2991              
  Lines      185952   185958       +6     
  Branches    20507    20518      +11     
==========================================
- Hits        52888    52764     -124     
- Misses     132270   132398     +128     
- Partials      794      796       +2     
Impacted Files Coverage Δ
...des-base/nodes/Google/Gmail/v2/DraftDescription.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Google/Gmail/v2/GmailV2.node.ts 0.00% <0.00%> (ø)
...s-base/nodes/Google/Gmail/v2/MessageDescription.ts 0.00% <ø> (ø)
.../nodes-base/nodes/Google/Gmail/GenericFunctions.ts 15.31% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-radency michael-radency merged commit fddc69e into master Jun 16, 2023
@michael-radency michael-radency deleted the node-544-gh-pr-gmail-add-reply-to-email branch June 16, 2023 08:44
MiloradFilipovic added a commit that referenced this pull request Jun 20, 2023
* master: (34 commits)
  feat(editor): Replace root events with event bus events (no-changelog) (#6454)
  feat(DebugHelper Node): Fix and include in main app (#6406)
  feat(Webhook Node): Stream binary response in `lastNode.firstEntryBinary` mode (#6463)
  fix(editor): Update git repo URL validation to prevent using https protocol (#6475)
  fix(editor): Remove tooltip about SMTP being required to invite user (no-changelog) (#6474)
  feat: Add support for large files with declarative nodes (#6461)
  fix(core): Fix the url sent in the password-reset emails (#6466)
  fix(HTML Node): Prevent XSS in execution-data preview (#6432)
  fix(Snowflake Node): Upgrade snowflake-sdk to address CVE-2023-34232 (no-changelog) (#6458)
  refactor(core): Replace lodash's "soft-deprecated" individual packages with `lodash` to resolve CVE (no-changelog) (#6450)
  fix(editor): Remove `$if`, `$min` and `$max` from code node autocomplete (#6460)
  fix(editor): Fix DNV header disappearing when scrolling the code editor content (#6459)
  feat: Remove vue-fragment (no-changelog) (#6456)
  ci: Prevent e2e failure on `commented` type review (no-changelog) (#6452)
  fix(LinkedIn Node): Remove unsupported description from image posts (#6446)
  fix(Split In Batches Node): Add "done" context to allow simple reset (#6437)
  feat(Gmail Node): Add reply to email (#6453)
  fix: Remove Vue.component usage and refactor plugins into Vue Plugins (no-changelog) (#6445)
  fix(editor): Show confirm on pull only when http response status is 409 (#6451)
  fix(editor): Update data pinning tooltip to match current behaviour (#6436)
  ...

# Conflicts:
#	packages/nodes-base/nodes/CompareDatasets/GenericFunctions.ts
#	packages/nodes-base/nodes/Merge/v2/GenericFunctions.ts
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants