Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Gmail Node): Add reply to email #4414

Closed
wants to merge 10 commits into from
Closed

fix(Gmail Node): Add reply to email #4414

wants to merge 10 commits into from

Conversation

feelgood-interface
Copy link
Contributor

Changes:

  • Add replyTo field for draft and message
  • Split additionalFields for send and reply (because not all fields overlap)
  • Fix replayToEmail() typo

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Oct 23, 2022
@feelgood-interface feelgood-interface changed the title fix(Gmail Node): add reply to email fix(Gmail Node): Add reply to email Jan 21, 2023
@Joffcom
Copy link
Member

Joffcom commented May 18, 2023

NODE-544

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label May 18, 2023
@michael-radency
Copy link
Contributor

Hello @feelgood-interface , thank you for your contribution, I did add some comments

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.08 ⚠️

Comparison is base (5819be5) 28.41% compared to head (3ba6d85) 28.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4414      +/-   ##
==========================================
- Coverage   28.41%   28.34%   -0.08%     
==========================================
  Files        2991     2991              
  Lines      185935   185941       +6     
  Branches    20499    20502       +3     
==========================================
- Hits        52839    52708     -131     
- Misses     132302   132439     +137     
  Partials      794      794              
Impacted Files Coverage Δ
...des-base/nodes/Google/Gmail/v2/DraftDescription.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Google/Gmail/v2/GmailV2.node.ts 0.00% <0.00%> (ø)
...s-base/nodes/Google/Gmail/v2/MessageDescription.ts 0.00% <ø> (ø)
.../nodes-base/nodes/Google/Gmail/GenericFunctions.ts 15.31% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-radency
Copy link
Contributor

Hello @feelgood-interface , I did update branch with master, update some wording, removed displayOptions from replyToSenderOnly to avoid breaking change. If everything good please let me know so we could merge this PR

@michael-radency
Copy link
Contributor

Hello @feelgood-interface , I could not merge this PR due to issues with tests, I did open new #6453 on n8n-io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants