Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tab visibility change detection when polling executions (no-changelog) #6311

Merged
merged 1 commit into from
May 24, 2023

Conversation

alexgrozav
Copy link
Member

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@alexgrozav alexgrozav changed the title feat: add tab visibility change detection when polling executions (no-changelog) feat: Add tab visibility change detection when polling executions (no-changelog) May 24, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: +0.04 🎉

Comparison is base (4b85433) 27.60% compared to head (da4d47b) 27.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6311      +/-   ##
==========================================
+ Coverage   27.60%   27.64%   +0.04%     
==========================================
  Files        2957     2958       +1     
  Lines      181205   181343     +138     
  Branches    19699    19726      +27     
==========================================
+ Hits        50023    50140     +117     
- Misses     130435   130456      +21     
  Partials      747      747              
Impacted Files Coverage Δ
...rc/components/ExecutionsView/ExecutionsSidebar.vue 61.93% <0.00%> (-2.50%) ⬇️
...ckages/editor-ui/src/components/ExecutionsList.vue 68.61% <65.21%> (+0.01%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@csuermann csuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a good opportunity to make sure we debounce refresh requests? Currently, when an instance is under load, refresh requests can pile up and degrade performance even more.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav
Copy link
Member Author

@csuermann it would indeed. I left a comment about that in the Linear ticket. Will pick it up when I'm back 🙏

@alexgrozav alexgrozav merged commit 071955b into master May 24, 2023
@alexgrozav alexgrozav deleted the pay-440-improvements-to-execution-list branch May 24, 2023 13:50
maspio pushed a commit that referenced this pull request May 25, 2023
…-changelog) (#6311)

feat: add tab visibility change detection when polling executions (no-changelog)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request Jun 1, 2023
* master: (54 commits)
  feat: Version control mvp (#6271)
  feat(editor): Implement Resource Mapper component (#6207)
  fix(editor): Update SSO settings styles (#6342)
  fix: Show `Ask AI` only on Code Node (#6336)
  feat(core): Add metadata (customdata) to event log (#6334)
  refactor: Add telemetry to upgrade paths (no-changelog) (#6313)
  fix(Code Node): Fix `item` and `items` alias regression (#6331)
  feat: Add manual login option and password reset link for SSO (#6328)
  fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333)
  fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322)
  fix(core): Prevent prototype pollution on injectable services (#6309)
  fix(core): Optimize getSharedWorkflowIds query (#6314)
  ci: Reset DB only once per e2e test (no-changelog) (#6216)
  feat(editor): Bring back checklist experiment (no-changelog) (#6307)
  fix: Add ldapts to nodes-base package (no-changelog) (#6315)
  fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318)
  feat: Add tab visibility change detection when polling executions (no-changelog) (#6311)
  fix(editor): Fix locale plularisation if count is 0 (#6312)
  🚀 Release 0.230.0 (#6310)
  fix(Execute Command Node): Block executions when `command` is empty (#6308)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants