-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Reset DB only once per e2e test (no-changelog) #6216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
netroy
force-pushed
the
fix-e2e-issues
branch
2 times, most recently
from
May 10, 2023 15:55
2740084
to
bda9cdb
Compare
netroy
changed the title
ci: Reset DB only once per e2e test (no-changelog)
ci: Reset DB only once per e2e test (no-changelog)
May 10, 2023
netroy
force-pushed
the
fix-e2e-issues
branch
2 times, most recently
from
May 12, 2023 15:22
1864701
to
292609b
Compare
netroy
force-pushed
the
fix-e2e-issues
branch
2 times, most recently
from
May 25, 2023 09:28
f8f9030
to
2f80644
Compare
This comment was marked as resolved.
This comment was marked as resolved.
OlegIvaniv
reviewed
May 26, 2023
OlegIvaniv
requested changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! There's just one place you've missed - 0.smoke.cy.ts. There we still resetAll
beforeEach, otherwise looks good to me.
Edit: Nvm, just realized we need to reset it there
OlegIvaniv
approved these changes
May 26, 2023
✅ All Cypress E2E specs passed |
csuermann
pushed a commit
that referenced
this pull request
May 26, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 1, 2023
* master: (54 commits) feat: Version control mvp (#6271) feat(editor): Implement Resource Mapper component (#6207) fix(editor): Update SSO settings styles (#6342) fix: Show `Ask AI` only on Code Node (#6336) feat(core): Add metadata (customdata) to event log (#6334) refactor: Add telemetry to upgrade paths (no-changelog) (#6313) fix(Code Node): Fix `item` and `items` alias regression (#6331) feat: Add manual login option and password reset link for SSO (#6328) fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333) fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322) fix(core): Prevent prototype pollution on injectable services (#6309) fix(core): Optimize getSharedWorkflowIds query (#6314) ci: Reset DB only once per e2e test (no-changelog) (#6216) feat(editor): Bring back checklist experiment (no-changelog) (#6307) fix: Add ldapts to nodes-base package (no-changelog) (#6315) fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318) feat: Add tab visibility change detection when polling executions (no-changelog) (#6311) fix(editor): Fix locale plularisation if count is 0 (#6312) 🚀 Release 0.230.0 (#6310) fix(Execute Command Node): Block executions when `command` is empty (#6308) ...
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.