Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reset DB only once per e2e test (no-changelog) #6216

Merged
merged 4 commits into from
May 26, 2023
Merged

Conversation

netroy
Copy link
Member

@netroy netroy commented May 10, 2023

No description provided.

@github-actions

This comment was marked as off-topic.

@codecov

This comment was marked as resolved.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 10, 2023
@netroy netroy force-pushed the fix-e2e-issues branch 2 times, most recently from 2740084 to bda9cdb Compare May 10, 2023 15:55
@netroy netroy changed the title ci: Reset DB only once per e2e test (no-changelog) ci: Reset DB only once per e2e test (no-changelog) May 10, 2023
@netroy netroy closed this May 10, 2023
@netroy netroy reopened this May 10, 2023
@netroy netroy marked this pull request as ready for review May 10, 2023 16:13
@netroy netroy force-pushed the fix-e2e-issues branch 2 times, most recently from 1864701 to 292609b Compare May 12, 2023 15:22
@netroy netroy force-pushed the fix-e2e-issues branch 2 times, most recently from f8f9030 to 2f80644 Compare May 25, 2023 09:28
@cypress

This comment was marked as resolved.

Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! There's just one place you've missed - 0.smoke.cy.ts. There we still resetAll beforeEach, otherwise looks good to me.

Edit: Nvm, just realized we need to reset it there

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 7a7b884 into master May 26, 2023
@netroy netroy deleted the fix-e2e-issues branch May 26, 2023 15:15
MiloradFilipovic added a commit that referenced this pull request Jun 1, 2023
* master: (54 commits)
  feat: Version control mvp (#6271)
  feat(editor): Implement Resource Mapper component (#6207)
  fix(editor): Update SSO settings styles (#6342)
  fix: Show `Ask AI` only on Code Node (#6336)
  feat(core): Add metadata (customdata) to event log (#6334)
  refactor: Add telemetry to upgrade paths (no-changelog) (#6313)
  fix(Code Node): Fix `item` and `items` alias regression (#6331)
  feat: Add manual login option and password reset link for SSO (#6328)
  fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333)
  fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322)
  fix(core): Prevent prototype pollution on injectable services (#6309)
  fix(core): Optimize getSharedWorkflowIds query (#6314)
  ci: Reset DB only once per e2e test (no-changelog) (#6216)
  feat(editor): Bring back checklist experiment (no-changelog) (#6307)
  fix: Add ldapts to nodes-base package (no-changelog) (#6315)
  fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318)
  feat: Add tab visibility change detection when polling executions (no-changelog) (#6311)
  fix(editor): Fix locale plularisation if count is 0 (#6312)
  🚀 Release 0.230.0 (#6310)
  fix(Execute Command Node): Block executions when `command` is empty (#6308)
  ...
@janober
Copy link
Member

janober commented Jun 5, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants