refactor(editor): Turn showMessage mixin to composable (#6081) #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(editor): move $getExecutionError from showMessages mixin to pushConnection (it is used there only) * refactor(editor): resolve showMessage mixin methods * fix(editor): use composable instead of mixin * fix(editor): resolve conflicts * fix(editor): replace clearAllStickyNotifications * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): remove last confirmMessage usage * fix(editor): remove $prompt usage * fix(editor): remove $show methods * fix(editor): lint fix * fix(editor): lint fix * fix(editor): fixes after review
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6244 +/- ##
==========================================
- Coverage 27.66% 27.39% -0.28%
==========================================
Files 2938 2937 -1
Lines 180015 180177 +162
Branches 19543 19557 +14
==========================================
- Hits 49805 49362 -443
- Misses 129479 130082 +603
- Partials 731 733 +2
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
alexgrozav
previously approved these changes
May 15, 2023
|
|
alexgrozav
previously approved these changes
May 15, 2023
|
|
alexgrozav
force-pushed
the
n8n-6358-showmessage
branch
from
2213614 to
8d3aeb2
Compare
alexgrozav
previously approved these changes
May 15, 2023
|
|
alexgrozav
approved these changes
May 15, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 16, 2023
* master: (22 commits) fix: Remove workflow execution credential error message when instance owner (#6116) refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257) feat(core): Return OAuth2 error body if available (#5794) fix: Add itemSize config to workflows view recycle scroller (no-changelog) (#6238) fix(editor): Fix close and cancel operations on useMessage (no-changelog) (#6260) feat(editor): Add cloud ExecutionsUsage and API blocking using licenses (#6159) refactor(editor): Turn showMessage mixin to composable (#6081) (#6244) feat(core): Add experimental proxy support to License-SDK (no-changelog) (#6253) feat(core): Reduce the number of events sent to Sentry (#6235) feat(editor): Drop support for legacy browsers that do not have native ESM support (#6239) refactor(editor): Add missing interface IUserListAction (no-changelog) (#6241) ci: Debug e2e pipeline (no-changelog) (#6240) Revert "refactor(editor): Turn showMessage mixin to composable" (#6243) feat(editor): Updating node reference pattern in expression editor (#6228) refactor(editor): Remove unused dependencies (no-changelog) (#6223) refactor(editor): Turn showMessage mixin to composable (#6081) feat(editor): Version Control settings update (WIP) (#6233) ci: Fix linting issue on master (no-changelog) (#6232) fix: Prevent type error messages for manual executions (no-changelog) (#6229) fix(Code Node): Restore help text (#6231) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(editor): move $getExecutionError from showMessages mixin to pushConnection (it is used there only)
refactor(editor): resolve showMessage mixin methods
fix(editor): use composable instead of mixin
fix(editor): resolve conflicts
fix(editor): replace clearAllStickyNotifications
fix(editor): replace confirmMessage
fix(editor): replace confirmMessage
fix(editor): replace confirmMessage
fix(editor): remove last confirmMessage usage
fix(editor): remove $prompt usage
fix(editor): remove $show methods
fix(editor): lint fix
fix(editor): lint fix
fix(editor): fixes after review
Github issue / Community forum post (link here to close automatically):