refactor(editor): Turn showMessage mixin to composable #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pushConnection (it is used there only)
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
# Conflicts: # packages/editor-ui/src/views/NodeView.vue
# Conflicts: # packages/editor-ui/src/mixins/showMessage.ts
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6081 +/- ##
=========================================
Coverage ? 27.58%
=========================================
Files ? 2937
Lines ? 180056
Branches ? 19550
=========================================
Hits ? 49672
Misses ? 129653
Partials ? 731
☔ View full report in Codecov by Sentry. |
ivov
previously approved these changes
May 10, 2023
|
|
# Conflicts: # packages/editor-ui/src/components/CredentialCard.vue # packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationCard.ee.vue # packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue # packages/editor-ui/src/components/WorkflowShareModal.ee.vue # packages/editor-ui/src/mixins/pushConnection.ts # packages/editor-ui/src/mixins/showMessage.ts # packages/editor-ui/src/views/NodeView.vue # packages/editor-ui/src/views/SettingsApiView.vue # packages/editor-ui/src/views/SetupView.vue # packages/editor-ui/src/views/SignupView.vue
ivov
approved these changes
May 12, 2023
|
|
cstuncsik
added a commit
that referenced
this pull request
May 12, 2023
This reverts commit b95fcd7.
cstuncsik
added a commit
that referenced
this pull request
May 12, 2023
cstuncsik
added a commit
that referenced
this pull request
May 12, 2023
cstuncsik
added a commit
that referenced
this pull request
May 12, 2023
* refactor(editor): move $getExecutionError from showMessages mixin to pushConnection (it is used there only) * refactor(editor): resolve showMessage mixin methods * fix(editor): use composable instead of mixin * fix(editor): resolve conflicts * fix(editor): replace clearAllStickyNotifications * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): remove last confirmMessage usage * fix(editor): remove $prompt usage * fix(editor): remove $show methods * fix(editor): lint fix * fix(editor): lint fix * fix(editor): fixes after review
alexgrozav
added a commit
that referenced
this pull request
May 15, 2023
* refactor(editor): Turn showMessage mixin to composable (#6081) * refactor(editor): move $getExecutionError from showMessages mixin to pushConnection (it is used there only) * refactor(editor): resolve showMessage mixin methods * fix(editor): use composable instead of mixin * fix(editor): resolve conflicts * fix(editor): replace clearAllStickyNotifications * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): replace confirmMessage * fix(editor): remove last confirmMessage usage * fix(editor): remove $prompt usage * fix(editor): remove $show methods * fix(editor): lint fix * fix(editor): lint fix * fix(editor): fixes after review * fix(editor): Fix external hook call in App * fix(editor): mixins & composables * fix: add pushConnection setup composables to components as well * fix(editor): mixins & composables * fix(editor): mixins & composables * fix: add void on non-await async calls * fix: fix close without connecting confirmation * fix: remove .only --------- Co-authored-by: Alex Grozav <[email protected]>
MiloradFilipovic
added a commit
that referenced
this pull request
May 16, 2023
* master: (22 commits) fix: Remove workflow execution credential error message when instance owner (#6116) refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257) feat(core): Return OAuth2 error body if available (#5794) fix: Add itemSize config to workflows view recycle scroller (no-changelog) (#6238) fix(editor): Fix close and cancel operations on useMessage (no-changelog) (#6260) feat(editor): Add cloud ExecutionsUsage and API blocking using licenses (#6159) refactor(editor): Turn showMessage mixin to composable (#6081) (#6244) feat(core): Add experimental proxy support to License-SDK (no-changelog) (#6253) feat(core): Reduce the number of events sent to Sentry (#6235) feat(editor): Drop support for legacy browsers that do not have native ESM support (#6239) refactor(editor): Add missing interface IUserListAction (no-changelog) (#6241) ci: Debug e2e pipeline (no-changelog) (#6240) Revert "refactor(editor): Turn showMessage mixin to composable" (#6243) feat(editor): Updating node reference pattern in expression editor (#6228) refactor(editor): Remove unused dependencies (no-changelog) (#6223) refactor(editor): Turn showMessage mixin to composable (#6081) feat(editor): Version Control settings update (WIP) (#6233) ci: Fix linting issue on master (no-changelog) (#6232) fix: Prevent type error messages for manual executions (no-changelog) (#6229) fix(Code Node): Restore help text (#6231) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.