fix(core): Ensure DB repositories are initialized before the DB migrations are run #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6220 +/- ##
=======================================
Coverage 19.96% 19.96%
=======================================
Files 2651 2651
Lines 119728 119717 -11
Branches 18934 18932 -2
=======================================
- Hits 23906 23904 -2
+ Misses 95094 95086 -8
+ Partials 728 727 -1
☔ View full report in Codecov by Sentry. |
|
✅ All Cypress E2E specs passed |
…tions are run also remove the need to re-open sqlite db connection
netroy
force-pushed
the
fix-db-calls-in-workflow-runnner
branch
from
4f5bf24 to
ac8b1b4
Compare
krynble
approved these changes
May 10, 2023
krynble
approved these changes
May 10, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 11, 2023
* master: feat(Google Ads Node): Update to support v13 (#6212) ci: Fix published nodes-base package's dependencies (no-changelog) (#6226) ci: Code coverage should include `.vue` files as well (no-changelog) (#6224) 🚀 Release 0.228.0 (#6219) ci: Fix linting issue on master (no-changelog) (#6222) fix(core): Ensure DB repositories are initialized before the DB migrations are run (#6220) refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642) ci: Increase timeout for DB tests (no-changelog) (#6221) fix(editor): Fix viewing and downloading of binary data (#6218) fix: Prevent unnecessary error messages also for data loaded flag (#6201) feat: Create NPM node (#6177) fix(editor): Fix polling trigger check for `runData` (#6130) ci: Fix linting issue on master (no-changelog) (#6217) fix: Prevent overflow when rendering expression hints (#6214) feat(core): Improve health check (#6205) refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204) fix(editor): Add loading skeletons to Executions list page (#6184) ci: Fix v1 docker rc builds (no-changelog) (#6208) feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209) fix: Correctly save executions that failed when polling as error instead of new (#6192) # Conflicts: # packages/editor-ui/src/components/ParameterInputList.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved this section to
migratein #6205 because when we close/re-open the connection, the repository instances held on to the original closed connection.But this change broke
WorkflowRunnerProcesswhich callsDb.init()but notDb.migrate.This also removes the code to re-open sqlite db connection, as it doesn't seem to be needed anymore.