Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Improve health check #6205

Merged
merged 4 commits into from
May 10, 2023
Merged

feat(core): Improve health check #6205

merged 4 commits into from
May 10, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 9, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 21.51% and no project coverage change.

Comparison is base (eae3a55) 19.94% compared to head (b468353) 19.94%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6205   +/-   ##
=======================================
  Coverage   19.94%   19.94%           
=======================================
  Files        2647     2647           
  Lines      119668   119681   +13     
  Branches    18929    18932    +3     
=======================================
+ Hits        23863    23871    +8     
- Misses      95078    95082    +4     
- Partials      727      728    +1
Impacted Files Coverage Δ
packages/cli/src/AbstractServer.ts 0.00% <0.00%> (ø)
packages/cli/src/CredentialsHelper.ts 25.49% <ø> (+0.24%) ⬆️
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
packages/cli/src/WorkflowExecuteAdditionalData.ts 12.40% <ø> (+0.06%) ⬆️
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/webhook.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/BaseCommand.ts 51.42% <20.00%> (-0.82%) ⬇️
packages/cli/src/Db.ts 52.52% <50.00%> (-3.73%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy changed the title feat(core): Improved health check feat(core): Improve health check May 9, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 9, 2023
@netroy netroy force-pushed the health-check-maintance-mode branch from 5ee099a to 52a662d Compare May 9, 2023 09:56
@netroy netroy marked this pull request as ready for review May 9, 2023 10:31
flipswitchingmonkey
flipswitchingmonkey previously approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@flipswitchingmonkey flipswitchingmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

✅ All Cypress E2E specs passed

@netroy netroy force-pushed the health-check-maintance-mode branch from 0d1421d to b468353 Compare May 9, 2023 19:48
@netroy netroy requested a review from flipswitchingmonkey May 9, 2023 19:49
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 9e7b9fb into master May 10, 2023
@netroy netroy deleted the health-check-maintance-mode branch May 10, 2023 08:27
@netroy netroy mentioned this pull request May 10, 2023
Merged
MiloradFilipovic added a commit that referenced this pull request May 11, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
67194f8 
* master:
  feat(Google Ads Node): Update to support v13 (#6212)
  ci: Fix published nodes-base package's dependencies (no-changelog) (#6226)
  ci: Code coverage should include `.vue` files as well (no-changelog) (#6224)
  🚀 Release 0.228.0 (#6219)
  ci: Fix linting issue on master (no-changelog) (#6222)
  fix(core): Ensure DB repositories are initialized before the DB migrations are run  (#6220)
  refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642)
  ci: Increase timeout for DB tests (no-changelog) (#6221)
  fix(editor): Fix viewing and downloading of binary data (#6218)
  fix: Prevent unnecessary error messages also for data loaded flag (#6201)
  feat: Create NPM node (#6177)
  fix(editor): Fix polling trigger check for `runData` (#6130)
  ci: Fix linting issue on master (no-changelog) (#6217)
  fix: Prevent overflow when rendering expression hints (#6214)
  feat(core): Improve health check (#6205)
  refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204)
  fix(editor): Add loading skeletons to Executions list page (#6184)
  ci: Fix v1 docker rc builds (no-changelog) (#6208)
  feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209)
  fix: Correctly save executions that failed when polling as error instead of new (#6192)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputList.vue
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @flipswitchingmonkey