Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Sort variables files under variables folder #6051

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (444ed1b) 18.72% compared to head (62c1be3) 18.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6051   +/-   ##
=======================================
  Coverage   18.72%   18.72%           
=======================================
  Files        2583     2582    -1     
  Lines      116526   116516   -10     
  Branches    18181    18181           
=======================================
  Hits        21821    21821           
+ Misses      94067    94057   -10     
  Partials      638      638           
Impacted Files Coverage Δ
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
...li/src/environments/variables/enviromentHelpers.ts 75.00% <ø> (ø)
.../environments/variables/variables.controller.ee.ts 85.71% <ø> (ø)
...src/environments/variables/variables.controller.ts 78.57% <ø> (ø)
...src/environments/variables/variables.service.ee.ts 100.00% <ø> (ø)
...li/src/environments/variables/variables.service.ts 80.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review April 21, 2023 10:45
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine in local tests, both api and executions.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit da31925 into master Apr 21, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the refactor-environments-folder branch April 21, 2023 11:08
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master: (47 commits)
  feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033)
  feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940)
  feat(core): Add license:info command (#6047)
  feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050)
  refactor(editor): Turn titleChange mixin to composable (#6059)
  test: Add stickies tests (#5413)
  refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057)
  fix(editor): Resolve expressions for grandparent nodes (#5859)
  ci(editor): Do not run parallel jobs for a single spec (no-changelog) (#6052)
  refactor(editor): Consolidate IN8nUISettings interface (#6055)
  refactor(core): Forbid raw enums (no-changelog)
  refactor(core): Sort variables files under variables folder (#6051)
  fix(core): Add breaking change record for domain and url matching (no-changelog) (#6048)
  feat(editor): Version control paywall (WIP) (#6030)
  feat(editor): Add disable template experiment (#5963)
  feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042)
  fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039)
  docs: Add proprietary license text (no-changelog) (#6038)
  test(n8n Node): Unit tests (no-changelog)
  refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014)
  ...

# Conflicts:
#	packages/cli/src/Server.ts
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants