Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) #6033

Merged
merged 5 commits into from
Apr 21, 2023
Merged

feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) #6033

merged 5 commits into from
Apr 21, 2023

Conversation

alexgrozav
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 20, 2023
cstuncsik
cstuncsik previously approved these changes Apr 20, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 68.08% and project coverage change: -0.01 ⚠️

Comparison is base (54f99a7) 18.64% compared to head (c3a1072) 18.64%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
- Coverage   18.64%   18.64%   -0.01%     
==========================================
  Files        2583     2584       +1     
  Lines      116471   116462       -9     
  Branches    18179    18180       +1     
==========================================
- Hits        21714    21710       -4     
+ Misses      94119    94114       -5     
  Partials      638      638
Impacted Files Coverage Δ
packages/editor-ui/src/main.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/utils/externalHooks.ts 38.88% <38.88%> (ø)
...ages/editor-ui/src/composables/useExternalHooks.ts 83.33% <75.00%> (ø)
packages/editor-ui/src/stores/nodeCreator.ts 16.41% <80.00%> (+0.28%) ⬆️
packages/editor-ui/src/mixins/copyPaste.ts 45.04% <100.00%> (ø)
packages/editor-ui/src/mixins/debounce.ts 48.27% <100.00%> (ø)
...kages/editor-ui/src/mixins/deviceSupportHelpers.ts 38.70% <100.00%> (ø)
packages/editor-ui/src/mixins/externalHooks.ts 100.00% <100.00%> (+28.57%) ⬆️
packages/editor-ui/src/mixins/restApi.ts 21.77% <100.00%> (ø)
packages/editor-ui/src/mixins/userHelpers.ts 55.55% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cstuncsik
cstuncsik previously approved these changes Apr 21, 2023
View reviewed changes
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav force-pushed the n8n-6268-replace-vueextend-with-definecomponent branch from a796bc1 to 7ef2510 Compare April 21, 2023 13:23
cstuncsik
cstuncsik previously approved these changes Apr 21, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 9c94050 into master Apr 21, 2023
@alexgrozav alexgrozav deleted the n8n-6268-replace-vueextend-with-definecomponent branch April 21, 2023 15:51
MiloradFilipovic added a commit that referenced this pull request Apr 21, 2023
@MiloradFilipovic
Merge branch 'master' into N8N-4244-remove-rest-api-mixin
33b4896 
* master:
  feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033)

# Conflicts:
#	packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts
#	packages/editor-ui/src/mixins/restApi.ts
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
ae6929d 
* master: (47 commits)
  feat: Replace Vue.extend with defineComponent in editor-ui (no-changelog) (#6033)
  feat(core): Add migration to add property userActivated to user settings (no-changelog) (#5940)
  feat(core): Add license:info command (#6047)
  feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) (#6050)
  refactor(editor): Turn titleChange mixin to composable (#6059)
  test: Add stickies tests (#5413)
  refactor: Patch to adjust `consistent-type-imports` (no-changelog) (#6057)
  fix(editor): Resolve expressions for grandparent nodes (#5859)
  ci(editor): Do not run parallel jobs for a single spec (no-changelog) (#6052)
  refactor(editor): Consolidate IN8nUISettings interface (#6055)
  refactor(core): Forbid raw enums (no-changelog)
  refactor(core): Sort variables files under variables folder (#6051)
  fix(core): Add breaking change record for domain and url matching (no-changelog) (#6048)
  feat(editor): Version control paywall (WIP) (#6030)
  feat(editor): Add disable template experiment (#5963)
  feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042)
  fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039)
  docs: Add proprietary license text (no-changelog) (#6038)
  test(n8n Node): Unit tests (no-changelog)
  refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014)
  ...

# Conflicts:
#	packages/cli/src/Server.ts
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@alexgrozav @sunilrr
feat: Replace Vue.extend with defineComponent in editor-ui (no-change…
1460e65 
…log) (n8n-io#6033)

* refactor: replace Vue.extend with defineComponent in editor-ui

* fix: change $externalHooks extractions from mixins

* fix: refactor externalHooks mixin
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @cstuncsik