Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Handle http error responses even when they are not a Buffer or a Stream (no-changelog) #5661

Closed
wants to merge 1 commit into from
Closed

fix(core): Handle http error responses even when they are not a Buffer or a Stream (no-changelog) #5661

wants to merge 1 commit into from

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 9, 2023

No description provided.

@netroy netroy added the skip-e2e label Mar 9, 2023
@netroy netroy requested a review from agobrech March 9, 2023 16:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy changed the title fic(core): Handle http error responses even when they are not a Buffer or a Stream (no-changelog) fix(core): Handle http error responses even when they are not a Buffer or a Stream (no-changelog) Mar 9, 2023
agobrech
agobrech approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netroy
Copy link
Member Author

netroy commented Mar 9, 2023

closing in favor of #5660

@netroy netroy closed this Mar 9, 2023
@netroy netroy deleted the fix-error-handling branch March 9, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netroy @agobrech