Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix trying to pipe a non stream on errors (no-changelog) #5660

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

agobrech
Copy link
Contributor

@agobrech agobrech commented Mar 9, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title fix(core): Fix trying to pipe a non stream on errors(no-changelog) fix(core): Fix trying to pipe a non stream on errors (no-changelog) Mar 9, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 9, 2023
@netroy netroy added the skip-e2e label Mar 9, 2023
@netroy netroy merged commit 5790e5e into master Mar 9, 2023
@netroy netroy deleted the fix-pipe-not-existing-on-error branch March 9, 2023 16:48
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 9, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 10, 2023
* master: (358 commits)
  refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649)
  🚀 Release 0.219.0 (#5659)
  fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660)
  ci: Fix e2e tests (no-changelog) (#5658)
  fix(core): Fix issues with LDAP reset and LDAP init (no-changelog) (#5657)
  feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610)
  feat(editor): Only redirect new users to blank canvas (no-changelog) (#5654)
  feat(editor): Do not automatically add manual trigger on node plus (#5644)
  feat(core): Allow using middlewares with decorators on a per-route basis (no-changelog) (#5656)
  refactor(core): Convert more routes to use the decorator pattern (no-changelog) (#5611)
  fix: Fetch credentials on workflows view to include in duplicated workflows (#5532)
  ci: Add PR checklist (#5628)
  feat(Mindee Node): Add support for v4 API (#5559)
  feat(Microsoft SQL Node): Add support for self signed certificates (#5160)
  fix(editor): Only fetch new versions at app launch (#5647)
  fix(core): Use new version of riot-tmpl in workflow package (no-changelog) (#5619)
  feat(core): Refactor and add SAML preferences for service provider instance (#5637)
  docs(Github Trigger Node): Add notice and more meaningful error around permissions (#5551)
  feat(Cal Trigger Node): Update to support v2 webhooks (#5331)
  feat(editor): Redirect users to canvas if they don't have any workflows (#5629)
  ...
@janober
Copy link
Member

janober commented Mar 10, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team skip-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants