Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Decouple REST calls from views (no-changelog) #5202

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@flipswitchingmonkey flipswitchingmonkey changed the title fix(editor: Decouple REST calls from views fix(editor): Decouple REST calls from views Jan 19, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 19, 2023
@csuermann csuermann changed the title fix(editor): Decouple REST calls from views refactor(editor): Decouple REST calls from views (no-changelog) Jan 20, 2023
alexgrozav
alexgrozav previously approved these changes Jan 20, 2023
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Awesome work.

state.items = deepCopy(state.items);
});
if (destination.id && destination.id in this.items) {
console.log(destination);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely not :)

@flipswitchingmonkey flipswitchingmonkey merged commit b69f480 into master Jan 20, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the ENG-35-remove-restapi-mixin-fromeventbus branch January 20, 2023 11:08
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 20, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 23, 2023
* master:
  fix(editor): Making parameter input components label configurable (#5195)
  feat(Google Analytics Node): Overhaul for google analytics node
  fix(Linear Node): Fix issue with single item not being returned (#5193)
  refactor: Update Notion nodes to remove beta from name (#4838)
  refactor(editor): Decouple REST calls from views (no-changelog) (#5202)
  test: Skip some syslog tests (no-changelog) (#5206)
  fix(Notion (Beta) Node): Fix create database page fails if relation param is empty/undefined (#5182)
  fix(core): Fix url in error handelling for the error Trigger (#5201)
  📚 Update CHANGELOG.md and main package.json to 0.212.0
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n
  🔖 Release [email protected]
  🔖 Release [email protected]
  fix(core): Revert rule @typescript-eslint/prefer-nullish-coalescing
  feat(core): Add Prometheus metrics for n8n events and api invocations (experimental) (#5177)
@janober
Copy link
Member

janober commented Jan 23, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants